search

TalonFloof / EnhancedWeather

Adds Localized Weather Systems to Minecraft
https://modrinth.com/mod/enhanced-weather
MIT License
19 stars 3 forks source link

Crash logging onto server #19

Closed b0b4444 closed 11 months ago

b0b4444 commented 1 year ago

Describe the bug I have a big modpack. Suddenly, when I log in my client crashes. When I do /enhancedweather killallOverworld on the server console, the server crashes.

To Reproduce Steps to reproduce the behavior:

  1. Install all mods
  2. Run server
  3. Log in on client
  4. Run Enhanced Weather Commands on server

Expected behavior Logging in without issue (as I have in the past)

Screenshots If applicable, add screenshots to help explain your problem.

System Information:

Additional context Opening of the crash log (which is attached): Description: Ticking entity

java.lang.NullPointerException: Cannot invoke "sh.talonfox.enhancedweather.weather.ServersideManager.getClosestCloud(net.minecraft.class_243, double, boolean, boolean, boolean, boolean, int)" because "sh.talonfox.enhancedweather.EnhancedWeather.SERVER_WEATHER" is null crash-2023-05-06_00.11.20-client.txt

PixelatedBruh commented 1 year ago

I will add on by saying i have got this exact same issue on my server my log is slightly different but the issue seams the same crash-2023-05-05_22.10.05-client.txt

  1. Log on to server
  2. Client Crash
TalonFloof commented 1 year ago

Hello @bob4444, thank you for reporting this. The client crash and the server crash is due to my code being built more for singleplayer or LAN multiplayer, and I haven't thoroughly tested multiplayer on a server yet. I will try to fix this today or tomorrow if possible. Thank you for reporting this.

b0b4444 commented 11 months ago

Any update on this? Was it resolved in the 1.20 update? If so, will you be updating the other game versions as well?

TalonFloof commented 11 months ago

I haven't fixed this yet, I'm currently working on other stuff and never got to doing that, though it is in my list of things to fix eventually. Technically the commands are for debugging purposes and weren't meant to be ran on a dedicated server, however I will try to fix this soon. Also unfortunately, this fix won't be backported to older versions, it will only be available for the latest version of Minecraft when it does get fixed, it just makes development easier.

TalonFloof commented 11 months ago

These issues have now been fixed on the latest version of Enhanced Weather ;3