TalonFloof / EnhancedWeather

Adds Localized Weather Systems to Minecraft
https://modrinth.com/mod/enhanced-weather
MIT License
19 stars 3 forks source link

Clouds render as fog color beyond a fairly limited range of the player, with peculiar chunky edges #32

Open floral-qua-floral opened 4 months ago

floral-qua-floral commented 4 months ago

Versions:

Cloud rendering seems to be affected by the vanilla Render Distance setting in a rather strange way. Beyond a particular distance which seems to scale linearly with Render Distance, clouds are fully rendered at the same color as the fog. This is especially noticeable at relatively low render distances, around 8, but still pretty noticeable at 12. This doesn't seem to be affected by the mod's Cloud Render Radius config setting. This is affected by the player's vertical distance to the clouds, not just the horizontal distance between a player's XZ coordinates and those of a particular cloud - moving close to the cloud height causes clouds further out to be colored properly, while moving further from the cloud layer causes the radius of properly rendered clouds to shrink.

Additionally, the transition between fully colored clouds and fog-colored clouds is strangely chunky-looking. These straight edges don't seem to actually correspond with chunk boundaries in the world, as the edges move smoothly with the motion of the clouds themselves. Each square 'chunk' of cloud is tinted almost (but not quite) uniformly by the fog, rather than there being a smooth transition like there is with terrain. It's hard to judge for sure, but I think the onset of the fog in the clouds might be noticeably closer than the terrain fog.

Here is a screenshot demonstrating the fog-colored clouds, with a Render Distance of 12 and a Cloud Render Radius of 16: image

Here is a screenshot demonstrating the peculiar borders, with a Render Distance of 8 and a Cloud Render Radius of 9: image

Love the mod, by the way! I've been keeping an eye out for a mod that adds wind that affects particles ever since I played with the original Weather2 mod years ago, so it was really exciting to find this. Looks great!

TalonFloof commented 4 months ago

Yea, I've noticed that it does that, it appears to be something that the buliltin Minecraft shader does for some reason, and I haven't been able to figure out how to fix it. You're free to look into it however if you so choose to.

CoffeeBomber commented 4 months ago

If you use a mod like Fog Looks Good Now, or Nostalgia Tweaks to get the old fog rendering it gets rid of the chunky edges but im still having trouble with the fog obscuring the clouds