Tam-Lin / comictagger

Automatically exported from code.google.com/p/comictagger
0 stars 0 forks source link

Search stopped returning meaningful results #39

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add a comic to the queue
2. Use Search Online, Auto-Identify, or Auto-Tag (Search Online is best to see 
this problem though)
3. Wait several minutes
4. In the list of search results, notice that there's thousands and thousands 
of results, 99.9% of which aren't relevant, as if it's returning the entire 
database of series titles.

What is the expected output? What do you see instead?
Should return just the few comic series that match the search query.

What version of the product are you using? On what operating system?
1.1.9beta Mac

Please provide any additional information below.
Been using ComicTagger 1.19beta on the Mac for a year or so now.  It's always 
worked great... a few minor bugs, like when it doesn't revert the mouse pointer 
back from the B&W pinwheel, but minor stuff.  Until, this week.  Now, whenever 
I search for a comic series, either using Search Online, Auto-Identify, or 
Auto-Tag, exactly like I always have, it searches for minutes at a time, and 
returns thousands of results... it looks like a list of every comic series 
ever.  You can manually scroll through the list and pick what you're looking 
for, but for some reason, the search functionality is totally broken all of a 
sudden.  I haven't done any updates or re-installs lately.  (Auto-Tag also only 
sometimes works now because of this.)  I've tried clearing the cache just in 
case, but it hasn't helped.  Is there any way I can post up some logs or 
something to help diagnose what's going wrong?  

Original issue reported on code.google.com by jbellanca on 29 Jan 2014 at 4:33

GoogleCodeExporter commented 9 years ago
Edit: Using OS X 10.9.1.  Try, for example, "The Dark Knight Returns" or 
"Legends of the Dark Knight"

Original comment by jbellanca on 29 Jan 2014 at 4:38

GoogleCodeExporter commented 9 years ago
From the forums: 

by anomander Yesterday at 7:54 am

It looks like the API has changed from AND to OR. So the longer the title you 
search for the more results you will get and its unlikely to ever get an exact 
match in the way it used to.

This needs a comictagger update to accommodate API changes but I have not seen 
the dev here since Aug 19, 2013 and the last code commit was one day before 
that.

To be fair in this period comictagger "just worked" so hopefull he will come 
back now it doesnt Smile

Update: Doesn't work was a bit harsh. In theory it should still work fine but 
its less than ideal when hundreds of results are presented and you have to 
manually eyeball the right one.

Original comment by jbellanca on 30 Jan 2014 at 12:15

GoogleCodeExporter commented 9 years ago
Exact same issue. Exact same results; i.e. no results but on Windows 7. I'll 
keep my fingers crossed for a fix. 

Original comment by loUrnaDoone on 30 Jan 2014 at 8:34

GoogleCodeExporter commented 9 years ago
This should fix it:

--- comictaggerlib/comicvinetalker.py~  2014-01-30 22:13:34.000000000 -0400
+++ comictaggerlib/comicvinetalker.py   2014-01-30 22:15:31.000000000 -0400
@@ -146,7 +146,7 @@

               original_series_name = series_name

-               series_name = urllib.quote_plus(series_name.encode("utf-8"))
+               series_name = urllib.quote_plus(series_name.replace(" "," AND 
").encode("utf-8"))
                #series_name = urllib.quote_plus(unicode(series_name))
                search_url = self.api_base_url + "/search/?api_key=" + self.api_key + "&format=json&resources=volume&query=" + series_name + "&field_list=name,id,start_year,publisher,image,description,count_of_issues"
                content = self.getUrlContent(search_url + "&page=1")

Original comment by sas...@gmail.com on 31 Jan 2014 at 2:21

GoogleCodeExporter commented 9 years ago
Excellent, thanks!  The new version fixed it perfectly!

Original comment by jbellanca on 1 Feb 2014 at 1:04

GoogleCodeExporter commented 9 years ago

Original comment by bevi...@gmail.com on 1 Feb 2014 at 2:45