Assignment review

[pierreh]

Done well:

• Clear commit history with work split in to smaller units
• Pointed out that artifacts belong in .gitignore
• Use of page object
• Clean reports with screenshots
• • Can the screen recordings be linked to the html report also?
• Nice choice of UI to test
• Good analysis of improvements to be done
• Made a good compromise between time spent and amount implemented
• Probed for security issues and user experience
• Expand on possible scenario's to implement

Feedback:

• I would put how to run the tests at the top of the Readme
• common/lib/base.js the convention would be to call this index.js
• common/lib/app.log should go to artifacts/logs
• Test 4 fails for me, it fails to click the seniority button
• minor: perhaps separate navigation from assertions in page object

• mui-2 type of selectors can easily break the tests if the UI is slightly rearranged. Instead the placeholder "Select a role" could have been used

[TamerNabil]

Thank you Pierreh for your review

• I updated the read-me file to have the how-to run at top
• Can the screen recordings be linked to the HTML report also? yes I think i can do that + put more logs too but this will take much time as I will make it as a custom report of HTML or Allure report but logically I can do it.
• "Test 4 fails for me, it fails to click the seniority button" , ok to reproduce I will need some more input about browser , and OS ... because currently, it works with my config so maybe it fails at something because I already faced some bugs with their UI during development
• "minor: perhaps separate navigation from assertions in page object" -> yes I totaly agree but since this was like a small thing so that's why I put both together

• mui-2 type of selectors can easily break the tests if the UI is slightly rearranged. Instead the placeholder "Select a role" could have been used - > Exactly , totally right but if I owned this project I was going to push to put good test-ids in multiple places

Thank you so much for the valuable comments, totally agree

[pierreh]

@TamerNabil Thank you for your response. Don't worry, I don't expect you to put more time in to this, I was just looking for your feedback :-)