TampaDevs / bayhacks.dev

Other
0 stars 0 forks source link

Extract out all text into single file, rm ui dependency #3

Closed CodaBool closed 1 year ago

CodaBool commented 1 year ago

πŸ΄β€β˜ οΈ Website

This is for https://bayhacks.dev but that doesn't have my changes live since this is a PR Live preview can be found at https://bayhacks.codabool.com

🚩 Context

I removed 2 dependencies and have moved all the text in both the classic view, modals, and from the 3d boxes into a single file.

This makes it very easy to update any text on the website. 99% of all text can be edited within the /text/index.jsx file.

There is possibly some issues that could come up with styling and fitting it within a box. However, this is still a major improvement on the scatter of text and styling that was happening before.

I cleaned up the way state works in the app. Should just be an overall improvement.

I moved away from using a ui package, it had bugs with it and I now build custom boxes with text that should have no bugs as well as be more performant. It is possible that there a runtime issue that will come out of this some some verification that the website works on all devices would be helpful.

πŸ§ͺ ❓ Test

So for I've tested this on

If someone could test out the website on Safari desktop and mobile that would be amazing.

πŸ› Known Bugs

Details > the mute button doesn't behave the way people would expect All the "mute" button does is pause the audio. Anything which turns it back on again un-pauses it. E.g. you click mute (which just pauses the audio). you open the video modal and close it. Closing the video modal unpauses the audio. This also happens when muting -> opening classic website / 2D view -> opening 3D view (always un-pauses audio) but that can be for a future update.