Tampermonkey / tampermonkey

Tampermonkey is the most popular userscript manager, with over 10 million users. It's available for Chrome, Microsoft Edge, Safari, Opera Next, and Firefox.
GNU General Public License v3.0
4.12k stars 413 forks source link

Scripts auto-updates do not work #1137

Open glubsy opened 3 years ago

glubsy commented 3 years ago

Expected Behavior

After the notification of a new update available for a user script, the update should be applied.

Actual Behavior

The notification is displayed for a new update available, but the patch is not applied.

Specifications

Script

All scripts are affect. I mainly test with scripts hosted on greasyfork.org.

After clicking on the "Last Updated" column, the spinner shows up, a (native) notification pops up saying that an update is available, click the notification to update, but then nothing happens. The script is not properly updated.

I have checked other issue tickets on the topic, but they seem irrelevant. There is no server cache going on here since the notification clearly states it found an update.

Manually updating the script works and displays the diff as expected.

derjanb commented 3 years ago

Can not reproduce (at Ubuntu).

Does clicking at the notification generated by this script log true?

// ==UserScript==
// @name         Test notification
// @namespace    http://tampermonkey.net/
// @version      0.1
// @description  try to take over the world!
// @author       You
// @match        https://github.com/*
// @grant        GM.notification
// ==/UserScript==

(async () => {
    try {
        console.log("returns:", await GM.notification({ text: "test message" }));
    } catch (ex) {
        console.error("error:", ex);
    }
})();
glubsy commented 3 years ago

Thanks for the reply. This generates returns: false for me. I'm on Arch Linux, and my notification daemon is dunst, so it probably doesn't register user feedback through notification.

Either way, I doubt this is a very good idea to rely on notification popups. If I select "Trigger update" from the drop-down menu and click start, the update should be applied immediately, regardless of the notification's callback.

gh0sti commented 4 months ago

I am on 5.1 and my script for better xcloud won't update