Closed Svenum closed 5 months ago
Now Its working again. I also added a Github Action to check If the nix Packages build right.
I don't know what @TamtamHero thinks about Github actions and whether or not there should be any, so they may have to be removed at some point.
Ok, I quickly reviewed the PR and there are a few things that should be changed. I am not familiar with NixOs and flakes so please tell me if I say anything wrong.
- specify an installation destination directory (
--dest-dir <installation destination directory (defaults to /)>
).- specify an installation prefix directory (
--prefix-dir <installation prefix directory (defaults to /usr)>
).- specify a default configuration directory (
--sysconf-dir <system configuration destination directory (defaults to /etc)>
).- disable ectool installation and service activation (
--no-ectool
)- disable post-install process (
--no-post-install
)
watchdog
and lm_sensors
) as they are no longer needed.
What are your thoughts on this?I don't know what @TamtamHero thinks about Github actions and whether or not there should be any, so they may have to be removed at some point.
Is fine for me. The only thing this action does is build the two nix packages and thats it. (Just to explain to you) :+1:
Ok, I quickly reviewed the PR and there are a few things that should be changed. I am not familiar with NixOs and flakes so please tell me if I say anything wrong.
- Firstly, we should now use the install script instead of moving the files manually. There are now options that you can use to specify the various output directories and disable parts of it, and I am open to creating more if needed.
-> Ok, I have implemented this as far as it gets in nix. The Service and every file you lay under /etc
have to be declared in an module (as far as I know). Thats why I remove the /lib
and /etc
paths afterwards.
- We also can remove the dependencies (
watchdog
andlm_sensors
) as they are no longer needed. What are your thoughts on this?
-> Done :+1:
I don't know what @TamtamHero thinks about Github actions and whether or not there should be any, so they may have to be removed at some point.
I'm fine with it :+1:
And another week. Is anything blocking this PR and I did not read it?
Looks good from my end :)
Just synced the nix branch
@leopoldhub please check my answers and the new code. :smile:
I will check everything one more time, but it should be good 👍
Congratulations 🎉 All is well on my end, thanks again for all your hard work and contribution to this project! @Svenum , would you like to be assigned automatically when a nix-related issue is opened?
Yes, I would love too help in the future on the nix side of this project. So assigning me is fine :+1:
I try to add the nixos flake, but I am not very experienced. So if you want to help, fell free. :smile: