TamtamHero / fw-fanctrl

A simple systemd service to better control Framework Laptop's fan(s)
BSD 3-Clause "New" or "Revised" License
201 stars 35 forks source link

Add NixOS Flake #26

Closed Svenum closed 5 months ago

Svenum commented 6 months ago

I try to add the nixos flake, but I am not very experienced. So if you want to help, fell free. :smile:

Svenum commented 5 months ago

Now Its working again. I also added a Github Action to check If the nix Packages build right.

leopoldhub commented 5 months ago

I don't know what @TamtamHero thinks about Github actions and whether or not there should be any, so they may have to be removed at some point.

leopoldhub commented 5 months ago

Ok, I quickly reviewed the PR and there are a few things that should be changed. I am not familiar with NixOs and flakes so please tell me if I say anything wrong.

Svenum commented 5 months ago

I don't know what @TamtamHero thinks about Github actions and whether or not there should be any, so they may have to be removed at some point.

Is fine for me. The only thing this action does is build the two nix packages and thats it. (Just to explain to you) :+1:

Ok, I quickly reviewed the PR and there are a few things that should be changed. I am not familiar with NixOs and flakes so please tell me if I say anything wrong.

  • Firstly, we should now use the install script instead of moving the files manually. There are now options that you can use to specify the various output directories and disable parts of it, and I am open to creating more if needed.

-> Ok, I have implemented this as far as it gets in nix. The Service and every file you lay under /etc have to be declared in an module (as far as I know). Thats why I remove the /lib and /etc paths afterwards.

  • We also can remove the dependencies (watchdog and lm_sensors) as they are no longer needed. What are your thoughts on this?

-> Done :+1:

TamtamHero commented 5 months ago

I don't know what @TamtamHero thinks about Github actions and whether or not there should be any, so they may have to be removed at some point.

I'm fine with it :+1:

Svenum commented 5 months ago

And another week. Is anything blocking this PR and I did not read it?

thomaseizinger commented 5 months ago

Looks good from my end :)

leopoldhub commented 5 months ago

Just synced the nix branch

Svenum commented 5 months ago

@leopoldhub please check my answers and the new code. :smile:

leopoldhub commented 5 months ago

I will check everything one more time, but it should be good 👍

leopoldhub commented 5 months ago

Congratulations 🎉 All is well on my end, thanks again for all your hard work and contribution to this project! @Svenum , would you like to be assigned automatically when a nix-related issue is opened?

Svenum commented 5 months ago

Yes, I would love too help in the future on the nix side of this project. So assigning me is fine :+1: