TamtamHero / fw-fanctrl

A simple systemd service to better control Framework Laptop's fan(s)
BSD 3-Clause "New" or "Revised" License
178 stars 33 forks source link

Rewrite of the install script to improve safety, maintainability and modularity #28

Closed leopoldhub closed 3 months ago

leopoldhub commented 3 months ago
leopoldhub commented 3 months ago

In this version, services and service sub-configurations are separated from the main script.

Services should be placed at the root of the 'services' folder and end with '.service'. Service sub-configurations should be placed in a folder with the name of the service, again at the root of the 'services' folder.

1ctual configuration:

services/
├── fw-fanctrl.service
└── system-sleep
    └── fw-fanctrl-suspend

During installation, environment variables in these files are replaced with their values ($HOME by /home/...) using envsubst.

TamtamHero commented 3 months ago

Can you also change the readme to remove the mention about the config file being overwritten with update ? This line should be erased: It will overwrite the config file, so you might want to back it up if you have a custom one !

Good to merge after that

leopoldhub commented 3 months ago

yes, no problem, I will also change one of the forgotten links about the ectool repo

TamtamHero commented 3 months ago

I fixed that directly on main an hour ago :pig:

leopoldhub commented 3 months ago

~mb x)~

nah, seems like one was forgotten :p

TamtamHero commented 3 months ago

Well, thanks for this PR, it's definitely cleaner and doesn't look like it's gonna break anything for current users

leopoldhub commented 3 months ago

Thank you for your time

I will certainly be back for the main python script