TamtamHero / fw-fanctrl

A simple systemd service to better control Framework Laptop's fan(s)
BSD 3-Clause "New" or "Revised" License
192 stars 35 forks source link

Usage of pipfile for requirements.txt replacement #32

Closed leopoldhub closed 2 months ago

leopoldhub commented 4 months ago

Hi,

Would you be in favor of using pipfile for dependency management over the traditional requirements.txt? This would mainly allow us to keep production and dev dependencies separate, as well as requiring a minimum Python version.

Here is the documentation if you want to know more about it.

TamtamHero commented 4 months ago

Actually, I merged #29 without realizing that requirements.txt is now empty. Very satisfying. Shouldn't we simply remove it, update the install script to remove the pip call and try our best to never add dependencies in the future, rather that adding unused boilerplate for pipfile ?

leopoldhub commented 4 months ago

We could remove it for now, but having the possibility to add dev dependencies for code quality would be nice too

TamtamHero commented 4 months ago

Ok, be my guest then

leopoldhub commented 2 months ago

irrelevant for now as we do not have the need for libraries yet. Might re-open later if needed.