search

Tamunokuro / Space-Travelers-hub

This is a simple React.js application that shows different ship missions and allows for users to book a rocket for a mission
1 stars 0 forks source link

Rockets list render functionality #32

Closed Tamunokuro closed 1 year ago

Tamunokuro commented 1 year ago
jorgegoco commented 1 year ago

STATUS: CHANGES REQUIRED ♻️

Hi @Tamunokuro 👋,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights 🎯

✔️ Descriptive PR ✔️ Good commit history ✔️ No linter errors

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

jorgegoco commented 1 year ago

Status: Approved :heavy_check_mark:

Hi @Tamunokuro

Your project is complete! Great job for making the requested changes 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations! 🎉💯🌟

Good Points 👍


Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀

tufoin

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.