Inform Charles

[TanNgocDo]

I have submit my homework. Could you please check it for me /cc @chug2k ?

[chug2k]

Full-featured submission. Very good job. I really like the animation on the move details page.

I didn't mention this in class, but please be sure to follow the Swift code styling conventions for the homework. Here are a few useful guides:

• Ray Wenderlich Swift Style Guide
• Github Swift Style Guide

Your code is pretty close to the style guide, so good job. You are occasionally inconsistent with your brackets - sometimes you write:

if something {
  body
}

and sometimes you use

if something
{
  body
}

The first form is generally more accepted according to the style guides.

In class I only used a NSDictionary, but it would have been nice if you implemented a model class. The SwiftyJSON library is useful for this - https://github.com/SwiftyJSON/SwiftyJSON.

• Nice work with the custom Movie cell.
• Nice work loading the images asynchronously, and nice job with the fade!
• Nice work implementing the error message on network failure. Next time consider using UIView.animateWithDuration to fade or slide the message instead of just hide and show.
• You could also use your displayNetworkStatus function in your failure block to setImageWithURLRequest instead of just calling NSLog.

Great job with the search and the tab bar, but I did find a bug with your search:

This happens when you scroll while search is active. You should probably make the filters array equal to the movies array by default, so an empty search query is still valid.

Overall, excellent submission.

[TanNgocDo]

Thank you very much for your very clear feedback, Charles ! I will pay more attention in coding style in next homeworks. With your hint I will f fix my crash. I also know about SwiftyJSON . It's cool!
Further more, I need to refactor my code to some design pattern. It is not good to write code like my current code.

Last but not least, Thank you for taking time to review very clearly!

[chug2k]

:smile: