search

TanNgocDo / yelp

Simple Yelp
0 stars 0 forks source link

Inform Charles #2

Open TanNgocDo opened 9 years ago

TanNgocDo commented 9 years ago

I have submit my homework. Could you please check it for me /cc @chug2k ? This submission is bad :(

chug2k commented 9 years ago

Thanks for the submission :clap:

The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. It was hard! You did fine with AutoLayout...except on the filters page. If I rotate the page, the labels move around: image

image

The filters page is a little ugly :frog: but good work.

TanNgocDo commented 9 years ago

Thank you for your review, Charles :)

I forgot about auto-layout in Filter page :(

I have not done well for this exercise. Sometimes, stuck in several hours for a silly bug :( I think with a IOS newbie like me, I need to take more times(at least 20 hours) to finish all the features of a exercise -> fighting longer Anyways, I will not stop doing the weekly assignments . After this course, I will refactor all code from week 1 to week 6, try to finish the missing parts (and adding more) . I will inform you when I finsh :)

See you this evening :)

On 10 September 2015 at 13:20, Charles Lee notifications@github.com wrote:

Thanks for the submission [image: :clap:]

The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. It was hard! You did fine with AutoLayout...except on the filters page. If I rotate the page, the labels move around: [image: image] https://cloud.githubusercontent.com/assets/44512/9781436/7d76c6e8-57be-11e5-9b49-bc9b9658f111.png

[image: image] https://cloud.githubusercontent.com/assets/44512/9781435/7841094a-57be-11e5-8117-19a7bdae81ee.png

  • Nice work linking the filter model with the controls. For an alternative to implementing forms manually, you can check out XLForm: https://github.com/xmartlabs/XLForm
  • Nice work connecting the view controllers via the custom filter delegates. This is a popular pattern for handling events between view controllers.
  • Interesting idea to click the section header to expand choices. Usually you click on the currently selected option to expand the menu, but yours is interesting too.

The filters page is a little ugly [image: :frog:] but good work.

— Reply to this email directly or view it on GitHub https://github.com/TanNgocDo/yelp/issues/2#issuecomment-139128023.

chug2k commented 9 years ago

Feel free to ask me questions when you are stuck! I may not be able to help you...but I can try. That is my job. :smile:

On Thu, Sep 10, 2015 at 1:37 PM TanNgocDo notifications@github.com wrote:

Thank you for your review, Charles :)

I forgot about auto-layout in Filter page :(

I have not done well for this exercise. Sometimes, stuck in several hours for a silly bug :( I think with a IOS newbie like me, I need to take more times(at least 20 hours) to finish all the features of a exercise -> fighting longer Anyways, I will not stop doing the weekly assignments . After this course, I will refactor all code from week 1 to week 6, try to finish the missing parts (and adding more) . I will inform you when I finsh :)

See you this evening :)

On 10 September 2015 at 13:20, Charles Lee notifications@github.com wrote:

Thanks for the submission [image: :clap:]

The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. It was hard! You did fine with AutoLayout...except on the filters page. If I rotate the page, the labels move around: [image: image] < https://cloud.githubusercontent.com/assets/44512/9781436/7d76c6e8-57be-11e5-9b49-bc9b9658f111.png

[image: image] < https://cloud.githubusercontent.com/assets/44512/9781435/7841094a-57be-11e5-8117-19a7bdae81ee.png

  • Nice work linking the filter model with the controls. For an alternative to implementing forms manually, you can check out XLForm: https://github.com/xmartlabs/XLForm
  • Nice work connecting the view controllers via the custom filter delegates. This is a popular pattern for handling events between view controllers.
  • Interesting idea to click the section header to expand choices. Usually you click on the currently selected option to expand the menu, but yours is interesting too.

The filters page is a little ugly [image: :frog:] but good work.

— Reply to this email directly or view it on GitHub https://github.com/TanNgocDo/yelp/issues/2#issuecomment-139128023.

— Reply to this email directly or view it on GitHub https://github.com/TanNgocDo/yelp/issues/2#issuecomment-139130672.

TanNgocDo commented 9 years ago

Thank you for your kindness, Charles 😂

On 10 September 2015 at 13:40, Charles Lee notifications@github.com wrote:

Feel free to ask me questions when you are stuck! I may not be able to help you...but I can try. That is my job. :smile:

On Thu, Sep 10, 2015 at 1:37 PM TanNgocDo notifications@github.com wrote:

Thank you for your review, Charles :)

I forgot about auto-layout in Filter page :(

I have not done well for this exercise. Sometimes, stuck in several hours for a silly bug :( I think with a IOS newbie like me, I need to take more times(at least 20 hours) to finish all the features of a exercise -> fighting longer Anyways, I will not stop doing the weekly assignments . After this course, I will refactor all code from week 1 to week 6, try to finish the missing parts (and adding more) . I will inform you when I finsh :)

See you this evening :)

On 10 September 2015 at 13:20, Charles Lee notifications@github.com wrote:

Thanks for the submission [image: :clap:]

The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. It was hard! You did fine with AutoLayout...except on the filters page. If I rotate the page, the labels move around: [image: image] <

https://cloud.githubusercontent.com/assets/44512/9781436/7d76c6e8-57be-11e5-9b49-bc9b9658f111.png

[image: image] <

https://cloud.githubusercontent.com/assets/44512/9781435/7841094a-57be-11e5-8117-19a7bdae81ee.png

  • Nice work linking the filter model with the controls. For an alternative to implementing forms manually, you can check out XLForm: https://github.com/xmartlabs/XLForm
  • Nice work connecting the view controllers via the custom filter delegates. This is a popular pattern for handling events between view controllers.
  • Interesting idea to click the section header to expand choices. Usually you click on the currently selected option to expand the menu, but yours is interesting too.

The filters page is a little ugly [image: :frog:] but good work.

— Reply to this email directly or view it on GitHub https://github.com/TanNgocDo/yelp/issues/2#issuecomment-139128023.

— Reply to this email directly or view it on GitHub https://github.com/TanNgocDo/yelp/issues/2#issuecomment-139130672.

— Reply to this email directly or view it on GitHub https://github.com/TanNgocDo/yelp/issues/2#issuecomment-139130945.