TanNhatCMS / df-frontend-2023

https://df-frontend-2023.vercel.app
1 stars 0 forks source link

Submission for assignment 1 #1

Open TanNhatCMS opened 1 year ago

TanNhatCMS commented 1 year ago
zlatanpham commented 1 year ago

Hello @TanNhatCMS, great work!

Requirements

Final result: ✅ passed

Feedback

We also have some comments for your work:

  1. Should keep the function naming consistency.There is a mix of myFunction and MyFunction use in the code.
  2. Should wrap JSON parse inside a try-catch and consider providing validation for the data.

You also got a 🔥 for demonstrating good use of semantic HTML as well as your implementation of add-on features such as pagination and multiple languages.