Open TanNhatCMS opened 11 months ago
Hello @TanNhatCMS, good work!
Final result: ✅ passed 90% of the requirements
We also have some comments for your work:
app.js
seems to be doing a lot. You might want to consider splitting out some of its functionalities into separate components or custom hooks. For example, the theme provider can be in a separate part.Array(pageCount).fill(0).map()
is a bit implicit. Consider using Array.from({length: page Count}, (_, index) => ...)
instead.
https://github.com/TanNhatCMS/df-frontend-2023/blob/6cda304e120cf08307d46e5b5b8e77fa81621719/assignment-2/src/view/components/Pagination.js#L50-L51handleActions
to something more descriptive. I would recommend passing two separate props onDelete
and onEdit
to make the code clearer.
https://github.com/TanNhatCMS/df-frontend-2023/blob/6cda304e120cf08307d46e5b5b8e77fa81621719/assignment-2/src/view/components/Table.js#L53-L56
Demo link: https://assignment-2.tannhatcms.xyz