Open TanNhatCMS opened 11 months ago
Hello @TanNhatCMS, good work!
Final result: ✅ passed 90% of the requirements
We also have some comments for your work:
type Theme = 'dark' | 'light'
.
https://github.com/TanNhatCMS/df-frontend-2023/blob/18ee04d8130804670e4f6903d9b8acc89568cd2b/assignment-3/src/AppController.tsx#L7PaginationBar
component
https://github.com/TanNhatCMS/df-frontend-2023/blob/18ee04d8130804670e4f6903d9b8acc89568cd2b/assignment-3/src/view/components/Pagination/PaginationBar.tsx#L54-L59Most of your TypeScript code is clean, but there are a few places where the type definitions for components are missing. To prevent this issue, consider changing the configuration setting noImplicitAny
to true
.
https://github.com/TanNhatCMS/df-frontend-2023/blob/18ee04d8130804670e4f6903d9b8acc89568cd2b/assignment-3/tsconfig.json#L15
Demo link: https://assignment-3.tannhatcms.xyz/