TanStack / query

🤖 Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.
https://tanstack.com/query
MIT License
40.1k stars 2.69k forks source link

docs: Fixed invalid links #7335

Closed jungwoo3490 closed 3 weeks ago

jungwoo3490 commented 3 weeks ago

Fixed https://github.com/TanStack/query/issues/7334

Hi :)

I fixed all invalid links in https://github.com/TanStack/query/blob/2ffd9fbd848c8ce4b62f354b21ae25a2040eeae2/docs/framework/react/quick-start.md

I checked all links correctly work.

https://github.com/TanStack/query/assets/60962533/1e66d462-9b51-4520-9a81-c25a90787bc4

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **query** | ⬜️ Ignored ([Inspect](https://vercel.com/tanstack/query/CSbfXkRJkAt1jdptLjo5xaremttT)) | [Visit Preview](https://query-git-fork-jungwoo3490-fix-invalid-links-tanstack.vercel.app) | | Apr 24, 2024 3:43pm |
codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d4df6c4740efc7ae18275c617cccafced0bfdc90:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration
TkDodo commented 3 weeks ago

@fulopkovacs I thought we have fixed all broken links already?

fulopkovacs commented 3 weeks ago

@TkDodo We did fix the links for the v5 docs, as you can see they are working in production (https://tanstack.com/query/latest/docs/framework/react/quick-start):

https://github.com/TanStack/query/assets/43729152/b61dd679-a8da-4984-9454-ceb15f890506

@jungwoo3490 Unfortunately, We can't trust VSCode errors in the case of relative links in the docs of the TanStack projects. This is related to the difference between how VSCode and TanStack router handle trailing slashes. See this comment for more info.

jungwoo3490 commented 3 weeks ago

Thanks for Checking!!! @fulopkovacs