search

TanStack / query

🤖 Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.
https://tanstack.com/query
MIT License
40.31k stars 2.7k forks source link

fix(angular-query): missing exports InitialDataInfiniteOptions types #7388

Closed Arthie closed 3 weeks ago

Arthie commented 3 weeks ago

Add missing @public js-doc comments in infinite-query-options.ts to fix type exports.

Currently the InitialDataInfiniteOptions types are not exported and can't be used. I assume this is due to the change to jsdoc and missing the @public comment for these types. This change would make this consistent with similar InitialDataOptions types form (query-options.ts).

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **query** | ⬜️ Ignored ([Inspect](https://vercel.com/tanstack/query/3oBFNsKgmoioV77NfuG8nGEm5av6)) | [Visit Preview](https://query-git-fork-arthie-patch-1-tanstack.vercel.app) | | May 7, 2024 10:14pm |
codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da3eab49a8aacf172e453346249b20022d0efd11:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration
nx-cloud[bot] commented 3 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit da3eab49a8aacf172e453346249b20022d0efd11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target - [`nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw --parallel=3`](https://cloud.nx.app/runs/58MpUbIH2z?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

arnoud-dv commented 3 weeks ago

They were in fact not exported by the main index.ts file. Added that and some other fixes to the public API types. Thanks!