search

TanStack / query

🤖 Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.
https://tanstack.com/query
MIT License
40.31k stars 2.7k forks source link

fix(svelte-query-devtools): Replace self-closing div tag #7440

Closed o-az closed 2 weeks ago

o-az commented 2 weeks ago

Svelte now warns whenever self-closing tags are used (except for ones where it's valid like <input />). This pr updates the self-closing <div /> to <div></div>. The result is that we have ones less warning in console. More reference here: https://github.com/sveltejs/svelte/issues/11052

https://github.com/o-az/query/blob/a4ad0e157a0a136b6afe2bb8c60517639373fd74/packages/svelte-query-devtools/src/Devtools.svelte#L61

https://github.com/o-az/query/blob/726ca42a6a258420e609ca4c0912ae02b107b009/packages/svelte-query-devtools/src/Devtools.svelte#L61

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **query** | ⬜️ Ignored ([Inspect](https://vercel.com/tanstack/query/FBC2MAGJLZtfcjM1UKKqtJLFnSy7)) | [Visit Preview](https://query-git-fork-o-az-fix-svelte-div-tanstack.vercel.app) | | May 17, 2024 0:28am |
codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ea05cd0a5063c151f6cc1482bc7807a5274df89:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration
nx-cloud[bot] commented 2 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6ea05cd0a5063c151f6cc1482bc7807a5274df89. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target - [`nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw --parallel=3`](https://cloud.nx.app/runs/a7jX3PAsZ0?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.