TanStack / query

🤖 Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.

https://tanstack.com/query

MIT License

40.31k stars 2.7k forks source link

fix(query-core): allow function value of `notifyOnChangeProps` query option to return `undefined` #7441

Open winghouchan opened 2 weeks ago

winghouchan commented 2 weeks ago

undefined is a valid return value for the function value of notifyOnChangeProps. See linked issue for more details.

Fixes #7426.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

TkDodo commented 2 weeks ago

can you amend the signature in the docs as well please?

nx-cloud[bot] commented 2 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 347c4d4166450a234b87dc4dd17a3df45f37783e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
`nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw --parallel=3`

✅ Successfully ran 1 target

- [`nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build,test:attw --parallel=3`](https://cloud.nx.app/runs/e1HaRROm28?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

TkDodo commented 2 weeks ago

also the jsdoc please:

https://github.com/TanStack/query/blob/3a8c2b10a1c2a3657d22b0304aab640683a4db0f/packages/query-core/src/types.ts#L319-L326