search

TanStack / query

🤖 Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.
https://tanstack.com/query
MIT License
41.91k stars 2.85k forks source link

the `coverage` in `vite.config.ts` causes unbound breakpoints when debugging internal packages #7757

Open Newbie012 opened 2 months ago

Newbie012 commented 2 months ago

Describe the bug

When trying to debug eslint-plugin-query using breakpoints, the code breaks on the wrong breakpoints. This is probably due to the changes made moving from tsup to vite. More specifically, this line:

https://github.com/TanStack/query/blob/ae8738acddcfd294c13da288cd3ac88302f250c0/packages/eslint-plugin-query/vite.config.ts#L11

When commented, the breakpoints are working as expected. I assume it happens because of how istanbul tracks the code coverage.

Your minimal, reproducible example

n/a (bug in the repo itself)

Steps to reproduce

  1. clone the repo
  2. pnpm i
  3. set a breakpoint in one of the lines of the packages eslint-plugin-query
  4. pnpm test:lib:dev
  5. see that the code stopped on a different line

Expected behavior

I expected the code to stop on the breakpoints I set ahead of time regardless of the coverage settings.

How often does this bug happen?

Every time

Screenshots or Videos

image image

Platform

Tanstack Query adapter

None

TanStack Query version

5.51.9 (irrelevant)

TypeScript version

5.3.3 (irrelevant)

Additional context

I haven't tested this behavior on other packages.

TkDodo commented 2 months ago

I've seen the same lately when debugging tests. @lachlancollins can we turn coverage off in general and only turn it on when we run tests in CI ?