search

TanStack / query

πŸ€– Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.
https://tanstack.com/query
MIT License
42.77k stars 2.93k forks source link

fix(eslint-plugin-query): relax property order rule to ignore relative order of getPreviousPageParam and getNextPageParam #8074

Closed schiller-manuel closed 2 months ago

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e7545cd7f0dbb98215658b262043c53dda077049. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution

βœ… Successfully ran 2 targets - [`nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3`](https://cloud.nx.app/runs/2g2RUj7GVY?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --exclude=examples/** --exclude=integrations/**`](https://cloud.nx.app/runs/boimTN9QHx?utm_source=pull-request&utm_medium=comment)

Sent with πŸ’Œ from NxCloud.

pkg-pr-new[bot] commented 2 months ago

Open in Stackblitz

More templates

- [@tanstack/query-example-angular-basic](https://pkg.pr.new/template/43a23c91-2a69-4deb-80e5-2c2cb458f53e) - [@tanstack/query-example-angular-infinite-query-with-max-pages](https://pkg.pr.new/template/f62df375-ceac-45a8-ad43-cd746ae37bc4) - [@tanstack/query-example-angular-router](https://pkg.pr.new/template/5dccb055-e289-4bf4-8a19-6580b69f852a) - [@tanstack/query-example-angular-simple](https://pkg.pr.new/template/238c724d-e150-4cef-a012-e27877bf656d) - [@tanstack/query-example-solid-astro](https://pkg.pr.new/template/6e8a8e12-34ea-428f-b4b8-13b61a577e3d) - [@tanstack/query-example-solid-basic](https://pkg.pr.new/template/c42b2c71-c260-4925-9ec5-c481e09c0fc1) - [@tanstack/query-example-solid-basic-graphql-request](https://pkg.pr.new/template/87adf08e-12b2-4031-be04-44ef66d13be5) - [@tanstack/query-example-solid-default-query-function](https://pkg.pr.new/template/7217e873-2a86-4414-a9ac-f5a456123ae9) - [@tanstack/query-example-solid-simple](https://pkg.pr.new/template/1ccae870-495d-4fe4-95cd-8d8c251b7b29) - [@tanstack/query-example-solid-start-streaming](https://pkg.pr.new/template/1f0fccb2-b87b-4285-8952-7bc46a7af37f) - [@tanstack/query-example-react-algolia](https://pkg.pr.new/template/fde6c0ea-ef89-40cd-a411-110e64b09ab0) - [@tanstack/query-example-react-auto-refetching](https://pkg.pr.new/template/318748d2-39d4-41a1-b83f-234531503bf5) - [@tanstack/query-example-react-basic](https://pkg.pr.new/template/aeb2fe57-457e-4887-a0b6-6c800952f47b) - [@tanstack/query-example-react-default-query-function](https://pkg.pr.new/template/dd5b2352-9c2c-43af-baa4-f07fa27945c7) - [@tanstack/query-example-react-basic-graphql-request](https://pkg.pr.new/template/c9c18fc0-40ea-4be9-9950-fa64fbbf9578) - [@tanstack/query-example-react-devtools-panel](https://pkg.pr.new/template/07784597-bb9f-43aa-a3ab-2d7f42642203) - [@tanstack/query-example-react-infinite-query-with-max-pages](https://pkg.pr.new/template/81ff0a76-86fe-4bae-9616-ce35a051bde6) - [@tanstack/query-example-react-load-more-infinite-scroll](https://pkg.pr.new/template/2948bcb6-a1f0-4b06-9716-85d85e35f0bd) - [@tanstack/query-example-react-nextjs](https://pkg.pr.new/template/9c47e10f-631a-453c-9199-419a43085964) - [@tanstack/query-example-react-nextjs-app-prefetching](https://pkg.pr.new/template/1a9ab088-c6a8-49f7-86b2-9e2242f0569b) - [@tanstack/query-example-nextjs-suspense-streaming](https://pkg.pr.new/template/47a0113b-5d65-4b75-9133-dc90c2420265) - [@tanstack/query-example-react-offline](https://pkg.pr.new/template/85c5a63b-2c47-49a4-8c4e-24e68d828b5f) - [@tanstack/query-example-react-optimistic-updates-cache](https://pkg.pr.new/template/a96f0fd6-c98f-4702-8c8b-feb428301fc6) - [@tanstack/query-example-react-optimistic-updates-ui](https://pkg.pr.new/template/78d8f972-93d8-48ad-a023-36aed6638e06) - [@tanstack/query-example-react-pagination](https://pkg.pr.new/template/edd46598-391e-4e44-8dc0-960c37009fd9) - [@tanstack/query-example-react-playground](https://pkg.pr.new/template/55428a57-57d8-429e-8643-480670587675) - [@tanstack/query-example-react-prefetching](https://pkg.pr.new/template/64f820ee-5c80-40ff-8229-5efd390e72d0) - [@tanstack/query-example-react-react-native](https://pkg.pr.new/template/dc9c23f9-2dc5-416f-b735-e31c7234aecf) - [@tanstack/query-example-react-router](https://pkg.pr.new/template/75010401-e6fe-4cef-8bbf-62e3334d87c1) - [@tanstack/query-example-react-rick-morty](https://pkg.pr.new/template/8d7c0f0a-aa28-4de4-b7c6-c07e59e96cb9) - [@tanstack/query-example-react-shadow-dom](https://pkg.pr.new/template/95d714bd-cb7e-41ff-844c-49a9d2043ddc) - [@tanstack/query-example-react-simple](https://pkg.pr.new/template/49bfcd51-6617-4f22-951b-efa6b7516a10) - [@tanstack/query-example-react-suspense](https://pkg.pr.new/template/a09c57c7-6151-4623-8c70-b3c5d609fb18) - [@tanstack/query-example-react-star-wars](https://pkg.pr.new/template/cbf39132-6e5c-40d2-9643-4be84407e063) - [@tanstack/query-example-vue-2.6-basic](https://pkg.pr.new/template/7c137541-337e-4312-bc36-0c0ee2712c9d) - [@tanstack/query-example-vue-2.7-basic](https://pkg.pr.new/template/502166a7-fede-4be8-add8-b6479dbf06d3) - [@tanstack/query-example-vue-basic](https://pkg.pr.new/template/8afb7b5b-ae9e-4c58-8876-e714264ee4e1) - [@tanstack/query-example-vue-dependent-queries](https://pkg.pr.new/template/a1250137-b107-4f6b-bcf0-8de68a6a5986) - [@tanstack/query-example-vue-nuxt3](https://pkg.pr.new/template/2944ef7a-dc09-4436-a663-207e153d644e) - [@tanstack/query-example-vue-persister](https://pkg.pr.new/template/18d35895-bc0e-4f72-b7ce-5ec5dd04d048) - [@tanstack/query-example-vue-simple](https://pkg.pr.new/template/b131ad15-4034-46fe-b0c1-8bfc21bc85e6) - [@tanstack/query-example-svelte-auto-refetching](https://pkg.pr.new/template/430499cb-ce8b-4c28-81f5-c7aabd344aa4) - [@tanstack/query-example-svelte-basic](https://pkg.pr.new/template/33563a0f-a280-4689-977c-258d0a7addb0) - [@tanstack/query-example-svelte-load-more-infinite-scroll](https://pkg.pr.new/template/22d6dd12-3653-4165-b74c-b8b5615fe84e) - [@tanstack/query-example-svelte-optimistic-updates](https://pkg.pr.new/template/bc2b010a-acb7-4e7a-855d-d17643a6f518) - [@tanstack/query-example-svelte-playground](https://pkg.pr.new/template/a3d34d2f-b813-456c-9804-9ab89ad4a6eb) - [@tanstack/query-example-svelte-simple](https://pkg.pr.new/template/63f76128-434e-4da2-a8d6-1a2bc6bbca2d) - [@tanstack/query-example-svelte-ssr](https://pkg.pr.new/template/93aeb90b-c3c2-4cb1-8dd0-2cb6fa6b98d1) - [@tanstack/query-example-svelte-star-wars](https://pkg.pr.new/template/713fc149-dbb9-4be2-8367-776d95759f5d)

@tanstack/angular-query-devtools-experimental

``` pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8074 ```

@tanstack/angular-query-experimental

``` pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8074 ```

@tanstack/eslint-plugin-query

``` pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8074 ```

@tanstack/query-async-storage-persister

``` pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8074 ```

@tanstack/query-broadcast-client-experimental

``` pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8074 ```

@tanstack/query-core

``` pnpm add https://pkg.pr.new/@tanstack/query-core@8074 ```

@tanstack/query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/query-devtools@8074 ```

@tanstack/query-persist-client-core

``` pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8074 ```

@tanstack/query-sync-storage-persister

``` pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8074 ```

@tanstack/react-query

``` pnpm add https://pkg.pr.new/@tanstack/react-query@8074 ```

@tanstack/react-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8074 ```

@tanstack/react-query-next-experimental

``` pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8074 ```

@tanstack/react-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8074 ```

@tanstack/solid-query

``` pnpm add https://pkg.pr.new/@tanstack/solid-query@8074 ```

@tanstack/solid-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8074 ```

@tanstack/solid-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8074 ```

@tanstack/svelte-query

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query@8074 ```

@tanstack/svelte-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8074 ```

@tanstack/svelte-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8074 ```

@tanstack/vue-query

``` pnpm add https://pkg.pr.new/@tanstack/vue-query@8074 ```

@tanstack/vue-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8074 ```

commit: e7545cd

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.89%. Comparing base (f8d65fb) to head (e7545cd). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/TanStack/query/pull/8074/graphs/tree.svg?width=650&height=150&src=pr&token=jqEbswkEDQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack)](https://app.codecov.io/gh/TanStack/query/pull/8074?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) ```diff @@ Coverage Diff @@ ## main #8074 +/- ## =========================================== + Coverage 44.97% 84.89% +39.92% =========================================== Files 199 15 -184 Lines 7362 490 -6872 Branches 1660 181 -1479 =========================================== - Hits 3311 416 -2895 + Misses 3674 57 -3617 + Partials 377 17 -360 ``` | [Components](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | Coverage Ξ” | | |---|---|---| | [@tanstack/angular-query-devtools-experimental](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/angular-query-experimental](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/eslint-plugin-query](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `84.89% <100.00%> (-2.26%)` | :arrow_down: | | [@tanstack/query-async-storage-persister](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-broadcast-client-experimental](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-codemods](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-core](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-persist-client-core](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-sync-storage-persister](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query-next-experimental](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/solid-query](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/solid-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/solid-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/svelte-query](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/svelte-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/svelte-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/vue-query](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/vue-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8074/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | |
Semigradsky commented 2 months ago

@schiller-manuel In v5.57.1 I see the error:

Oops! Something went wrong! :(

ESLint: 8.57.0

Error: Unsupported spread element
Occurred while linting /.../index.tsx:27
Rule: "@tanstack/query/infinite-query-property-order"
    at /home/dmitry/P/mp-web/node_modules/@tanstack/eslint-plugin-query/dist/cjs/rules/infinite-query-property-order/infinite-query-property-order.rule.cjs:55:21
    at Array.flatMap (<anonymous>)
    at Object.CallExpression (/home/dmitry/P/mp-web/node_modules/@tanstack/eslint-plugin-query/dist/cjs/rules/infinite-query-property-order/infinite-query-property-order.rule.cjs:48:42)
    at enhancedRuleInstructions.<computed> (/home/dmitry/P/mp-web/node_modules/@tanstack/eslint-plugin-query/dist/cjs/utils/detect-react-query-imports.cjs:44:77)
    at ruleErrorHandler (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/linter.js:1076:28)
    at /home/dmitry/P/mp-web/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/node-event-generator.js:326:22)

Previous version (5.56.1) works great.

The code is like this:

    const { data, isFetching, isLoading, hasNextPage, fetchNextPage } =
      useInfiniteQuery({
        ...communitiesQuery({
          filters: {
            ...fieldValues,
            placementFormats: ........,
          },
        }),
        refetchOnMount: false,
      })