TanStack / query

πŸ€– Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.
https://tanstack.com/query
MIT License
42.76k stars 2.92k forks source link

fix(eslint-plugin-query): correctly handle call-expression spread #8090

Closed schiller-manuel closed 2 months ago

schiller-manuel commented 2 months ago

this fixes the issue reported here: https://github.com/TanStack/query/pull/8074#issuecomment-2367340252

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 26c981eb178d87cbfdc916f1b43596b2ccc87c30. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 2 targets - [`nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3`](https://cloud.nx.app/runs/0sXM3iyfzN?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --exclude=examples/** --exclude=integrations/**`](https://cloud.nx.app/runs/EIVHjY4X0i?utm_source=pull-request&utm_medium=comment)

Sent with πŸ’Œ from NxCloud.

pkg-pr-new[bot] commented 2 months ago

Open in Stackblitz

More templates

- [@tanstack/query-example-angular-basic](https://pkg.pr.new/template/1e44d2f6-1170-4525-9b56-515f8d40df89) - [@tanstack/query-example-angular-infinite-query-with-max-pages](https://pkg.pr.new/template/967abb22-9479-4dc7-b921-b504f2917ba2) - [@tanstack/query-example-angular-router](https://pkg.pr.new/template/3093c889-7adf-436b-8550-043d03e1c42b) - [@tanstack/query-example-angular-simple](https://pkg.pr.new/template/57aae9ce-6183-4ad4-8945-ffbfdcd02b9f) - [@tanstack/query-example-solid-astro](https://pkg.pr.new/template/2466ab21-ced5-499a-9973-5e226a4626ff) - [@tanstack/query-example-solid-basic](https://pkg.pr.new/template/b50f605f-3360-431c-aa40-c7aede22a156) - [@tanstack/query-example-solid-basic-graphql-request](https://pkg.pr.new/template/8e4f0006-9a85-4ac3-bde9-42b591928eaa) - [@tanstack/query-example-solid-default-query-function](https://pkg.pr.new/template/45506a0c-d63f-4c47-b192-465a7bc6958b) - [@tanstack/query-example-solid-simple](https://pkg.pr.new/template/479e6c2b-7fda-43de-bb2f-bf13753e7030) - [@tanstack/query-example-solid-start-streaming](https://pkg.pr.new/template/fb3f29ea-15bb-42ae-b935-9e45b042c48e) - [@tanstack/query-example-react-algolia](https://pkg.pr.new/template/f34113a1-60b9-4c07-8220-2ee05520b807) - [@tanstack/query-example-react-auto-refetching](https://pkg.pr.new/template/f9d9fc36-34c9-4073-88f7-5721b94a4df1) - [@tanstack/query-example-react-basic](https://pkg.pr.new/template/2e6753af-53c4-4713-9908-25d296bed57b) - [@tanstack/query-example-react-basic-graphql-request](https://pkg.pr.new/template/35d02dee-3490-4160-9de3-2ad2b635dcf7) - [@tanstack/query-example-react-default-query-function](https://pkg.pr.new/template/2f595889-dbeb-40b8-bd7b-5f36e1c3b31c) - [@tanstack/query-example-react-devtools-panel](https://pkg.pr.new/template/943ef7ef-3d24-481b-8fdf-e8a8b0991232) - [@tanstack/query-example-react-infinite-query-with-max-pages](https://pkg.pr.new/template/8aa92570-b85d-4298-be0d-ca089851857b) - [@tanstack/query-example-react-load-more-infinite-scroll](https://pkg.pr.new/template/b7942caf-1ede-4a4a-91fb-ab71af3f3f87) - [@tanstack/query-example-react-nextjs](https://pkg.pr.new/template/c0e6f5a7-af61-4a30-bcec-265ca4d90773) - [@tanstack/query-example-react-nextjs-app-prefetching](https://pkg.pr.new/template/fbbab808-627c-4019-85a0-f445783887cb) - [@tanstack/query-example-nextjs-suspense-streaming](https://pkg.pr.new/template/696f4249-39c7-42c1-8e99-e23227e6429e) - [@tanstack/query-example-react-offline](https://pkg.pr.new/template/87534b16-1827-43b7-9109-d425c292d841) - [@tanstack/query-example-react-optimistic-updates-cache](https://pkg.pr.new/template/2836f5ce-c764-4a1f-a727-6db523403a45) - [@tanstack/query-example-react-optimistic-updates-ui](https://pkg.pr.new/template/2f268502-6a57-4009-afbe-179d0f2bc19d) - [@tanstack/query-example-react-pagination](https://pkg.pr.new/template/ba4c4582-4458-4db3-ad1c-e15afab927d9) - [@tanstack/query-example-react-playground](https://pkg.pr.new/template/676bbd7a-321e-4adf-8419-aea7e19eea92) - [@tanstack/query-example-react-prefetching](https://pkg.pr.new/template/50922173-d79c-4a66-8273-b9693ec9875b) - [@tanstack/query-example-react-react-native](https://pkg.pr.new/template/496d0e2d-74d6-4b8e-aa7f-791e8216dad7) - [@tanstack/query-example-react-router](https://pkg.pr.new/template/d7dab4f3-f0b4-4a27-9c52-b11a4352f9bb) - [@tanstack/query-example-react-rick-morty](https://pkg.pr.new/template/e6584b82-2b4b-4ca0-9a0d-29cf0d559c49) - [@tanstack/query-example-react-shadow-dom](https://pkg.pr.new/template/21bcc1d3-46a1-44cf-864f-089ebecfbf27) - [@tanstack/query-example-react-simple](https://pkg.pr.new/template/eb5eddc4-3ecb-4af9-9b1e-0680a415ef01) - [@tanstack/query-example-react-star-wars](https://pkg.pr.new/template/c06ab0f4-9dd1-47a9-8eeb-1dd032c21cf8) - [@tanstack/query-example-react-suspense](https://pkg.pr.new/template/c1a5dd28-6d36-4095-b520-bf97bab3497b) - [@tanstack/query-example-svelte-auto-refetching](https://pkg.pr.new/template/c102af4b-6885-4c67-b94f-1af7135c6b7d) - [@tanstack/query-example-svelte-basic](https://pkg.pr.new/template/b3805497-7821-42d1-ba7d-4e35d3eb7cd8) - [@tanstack/query-example-svelte-load-more-infinite-scroll](https://pkg.pr.new/template/113ed7ed-afa7-43b0-8f20-58050f615614) - [@tanstack/query-example-svelte-optimistic-updates](https://pkg.pr.new/template/e4a1f02f-1b77-498d-b4fc-8f68d42080e1) - [@tanstack/query-example-svelte-playground](https://pkg.pr.new/template/8f641269-24b8-4a37-9125-5528573b410d) - [@tanstack/query-example-svelte-simple](https://pkg.pr.new/template/c25d19d3-890d-48b0-9a08-578221caa255) - [@tanstack/query-example-svelte-ssr](https://pkg.pr.new/template/729b46eb-f0e3-45d3-bb01-ec9928150fea) - [@tanstack/query-example-svelte-star-wars](https://pkg.pr.new/template/7f908902-17ec-4a4b-9045-1babd431a4f2) - [@tanstack/query-example-vue-2.6-basic](https://pkg.pr.new/template/5eb71759-2f75-426a-b170-538c96fb7f89) - [@tanstack/query-example-vue-2.7-basic](https://pkg.pr.new/template/72e63f0d-53cc-44d7-9c7e-e08e906d1e27) - [@tanstack/query-example-vue-basic](https://pkg.pr.new/template/53dda1d4-85d7-4ff0-932d-5cbe5a74dd38) - [@tanstack/query-example-vue-dependent-queries](https://pkg.pr.new/template/ba365720-fc4d-439a-9b86-4f214812314b) - [@tanstack/query-example-vue-nuxt3](https://pkg.pr.new/template/0720953f-9a2b-484c-9943-e0e33f56f190) - [@tanstack/query-example-vue-persister](https://pkg.pr.new/template/e2d2b60f-c6af-402a-a3f6-468b45cbadfa) - [@tanstack/query-example-vue-simple](https://pkg.pr.new/template/aa64d391-f251-4f8e-9f47-3c89a8012365)

@tanstack/angular-query-experimental

``` pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8090 ```

@tanstack/angular-query-devtools-experimental

``` pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8090 ```

@tanstack/eslint-plugin-query

``` pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8090 ```

@tanstack/query-async-storage-persister

``` pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8090 ```

@tanstack/query-broadcast-client-experimental

``` pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8090 ```

@tanstack/query-core

``` pnpm add https://pkg.pr.new/@tanstack/query-core@8090 ```

@tanstack/query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/query-devtools@8090 ```

@tanstack/query-persist-client-core

``` pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8090 ```

@tanstack/query-sync-storage-persister

``` pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8090 ```

@tanstack/react-query

``` pnpm add https://pkg.pr.new/@tanstack/react-query@8090 ```

@tanstack/react-query-next-experimental

``` pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8090 ```

@tanstack/react-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8090 ```

@tanstack/react-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8090 ```

@tanstack/solid-query

``` pnpm add https://pkg.pr.new/@tanstack/solid-query@8090 ```

@tanstack/solid-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8090 ```

@tanstack/solid-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8090 ```

@tanstack/svelte-query

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query@8090 ```

@tanstack/svelte-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8090 ```

@tanstack/svelte-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8090 ```

@tanstack/vue-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8090 ```

@tanstack/vue-query

``` pnpm add https://pkg.pr.new/@tanstack/vue-query@8090 ```

commit: 26c981e

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (9da00d6) to head (26c981e). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/TanStack/query/pull/8090/graphs/tree.svg?width=650&height=150&src=pr&token=jqEbswkEDQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack)](https://app.codecov.io/gh/TanStack/query/pull/8090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) ```diff @@ Coverage Diff @@ ## main #8090 +/- ## =========================================== + Coverage 44.90% 87.80% +42.89% =========================================== Files 199 15 -184 Lines 7377 492 -6885 Branches 1666 182 -1484 =========================================== - Hits 3313 432 -2881 + Misses 3684 46 -3638 + Partials 380 14 -366 ``` | [Components](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | Coverage Ξ” | | |---|---|---| | [@tanstack/angular-query-devtools-experimental](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/angular-query-experimental](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/eslint-plugin-query](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `87.80% <75.00%> (+2.90%)` | :arrow_up: | | [@tanstack/query-async-storage-persister](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-broadcast-client-experimental](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-codemods](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-core](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-persist-client-core](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/query-sync-storage-persister](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query-next-experimental](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/react-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/solid-query](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/solid-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/solid-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/svelte-query](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/svelte-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/svelte-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/vue-query](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | | | [@tanstack/vue-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8090/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `βˆ… <ΓΈ> (βˆ…)` | |