search

TanStack / query

🤖 Powerful asynchronous state management, server-state utilities and data fetching for the web. TS/JS, React Query, Solid Query, Svelte Query and Vue Query.
https://tanstack.com/query
MIT License
42.72k stars 2.93k forks source link

fix: new cache entry check #8151

Closed jxom closed 1 month ago

jxom commented 1 month ago

Fixes https://github.com/wevm/wagmi/issues/4322

Seems that https://github.com/TanStack/query/pull/7988 introduced a subtle breaking change whereby the check for isNewCacheEntry would not account for a custom queryKeyHashFn. This is because the implementation of getQueryState does not pass custom options from the query to defaultQueryOptions. As a result, this broke consumer code that relyed on queryKeyHashFn to serialize bigints. This PR aims to access the cache directly with getQueryCache instead.

nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 81ff334fd6060d3eabecd55340a3a68a08d105be. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets - [`nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3`](https://cloud.nx.app/runs/bVymEUnjTC?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --exclude=examples/** --exclude=integrations/**`](https://cloud.nx.app/runs/AAEhoMiNQG?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

More templates

- [@tanstack/query-example-angular-basic](https://pkg.pr.new/template/7fa25632-f744-44d2-95b9-ab6d4f30f968) - [@tanstack/query-example-angular-infinite-query-with-max-pages](https://pkg.pr.new/template/cee72e35-420b-49a2-8c43-6a6d251b1dee) - [@tanstack/query-example-angular-pagination](https://pkg.pr.new/template/10e2b41a-d83d-49ea-9e6b-4c71919b53c5) - [@tanstack/query-example-angular-router](https://pkg.pr.new/template/1981df7c-0d31-46e9-8dd7-a54e16875d1e) - [@tanstack/query-example-angular-rxjs](https://pkg.pr.new/template/03d0b41a-bd47-4f36-9c02-4821340111db) - [@tanstack/query-example-angular-simple](https://pkg.pr.new/template/9ba55205-ac53-4d64-a88c-2b59362bc1e3) - [@tanstack/query-example-solid-astro](https://pkg.pr.new/template/3b0c2fde-ddfb-4f02-80dc-37aec7b1b6d1) - [@tanstack/query-example-solid-basic](https://pkg.pr.new/template/3f78a19a-e223-440e-877e-34431eff274e) - [@tanstack/query-example-solid-basic-graphql-request](https://pkg.pr.new/template/6db5132a-b5e3-482f-954b-48947d4ebd48) - [@tanstack/query-example-solid-default-query-function](https://pkg.pr.new/template/e626422b-6496-4ed4-9766-37f9d82dfef2) - [@tanstack/query-example-solid-simple](https://pkg.pr.new/template/18246341-4f72-4559-aa7a-76bb6d1adcf9) - [@tanstack/query-example-solid-start-streaming](https://pkg.pr.new/template/1e4052d3-b338-46da-8050-b28a9d618ad3) - [@tanstack/query-example-react-algolia](https://pkg.pr.new/template/daf84dfd-8d64-4e8f-bcd1-5d773e07eb5f) - [@tanstack/query-example-react-auto-refetching](https://pkg.pr.new/template/f0225e34-ad57-4b42-b882-92fa9db6f57a) - [@tanstack/query-example-react-basic](https://pkg.pr.new/template/e270f6cd-e15a-4998-a16d-e1762be62be2) - [@tanstack/query-example-react-basic-graphql-request](https://pkg.pr.new/template/7a708559-3028-4ef7-82cc-11cc758016b9) - [@tanstack/query-example-react-default-query-function](https://pkg.pr.new/template/6fc40490-b7ad-459b-b353-b72c6b6ba638) - [@tanstack/query-example-react-devtools-panel](https://pkg.pr.new/template/f8b62c75-1d48-4ad7-a1f7-56e762496a95) - [@tanstack/query-example-react-infinite-query-with-max-pages](https://pkg.pr.new/template/43dec78d-48ca-4f40-883c-6c7925f425ea) - [@tanstack/query-example-react-load-more-infinite-scroll](https://pkg.pr.new/template/f368dd74-fe47-43c7-a9f0-a3ee41e3d5d4) - [@tanstack/query-example-react-nextjs](https://pkg.pr.new/template/ac86cca8-7abe-44f9-8fa8-54ea7885a1f8) - [@tanstack/query-example-react-nextjs-app-prefetching](https://pkg.pr.new/template/9ecddf9e-71a3-429c-8f61-b08c4309dcc6) - [@tanstack/query-example-nextjs-suspense-streaming](https://pkg.pr.new/template/3743c468-2615-4cc9-9f1e-400cf018250f) - [@tanstack/query-example-react-optimistic-updates-cache](https://pkg.pr.new/template/dd3c7569-7881-455c-9ab4-506ef1ef6655) - [@tanstack/query-example-react-offline](https://pkg.pr.new/template/878ba16d-ba97-42c3-b586-57174b8567f1) - [@tanstack/query-example-react-optimistic-updates-ui](https://pkg.pr.new/template/1b072493-e8b3-4be1-a25e-638eeb8276a0) - [@tanstack/query-example-react-pagination](https://pkg.pr.new/template/0793ae65-b9c8-48a3-93d1-ec20b7cd6e2b) - [@tanstack/query-example-react-playground](https://pkg.pr.new/template/4b6754f3-9bd6-4eb3-a1ee-9e967fe7b292) - [@tanstack/query-example-react-prefetching](https://pkg.pr.new/template/cb73fd66-3ceb-4b0f-bcc8-3a801a157b27) - [@tanstack/query-example-react-react-native](https://pkg.pr.new/template/b804d122-dad6-4b6c-a0c6-e5dde75163cf) - [@tanstack/query-example-react-router](https://pkg.pr.new/template/b764e6f9-5f99-4592-ad76-7a242a55d33b) - [@tanstack/query-example-react-rick-morty](https://pkg.pr.new/template/e6c6240a-fbbd-48d2-bb81-cc670f58ba87) - [@tanstack/query-example-react-shadow-dom](https://pkg.pr.new/template/531e492a-cff1-4dff-b9b3-5985d8f7a793) - [@tanstack/query-example-react-simple](https://pkg.pr.new/template/fdef1362-cdb9-47e4-88a1-5826472531ff) - [@tanstack/query-example-react-star-wars](https://pkg.pr.new/template/dc4d9559-c023-415b-aead-746b1a3a9987) - [@tanstack/query-example-react-suspense](https://pkg.pr.new/template/6f5fa9ef-4e24-4c5f-8527-519e4505b22d) - [@tanstack/query-example-svelte-auto-refetching](https://pkg.pr.new/template/ef0bb497-010a-4a0a-b092-ffbd19cc4c67) - [@tanstack/query-example-svelte-basic](https://pkg.pr.new/template/f4c86243-7f3b-47bb-94e0-26b58d7f896b) - [@tanstack/query-example-svelte-optimistic-updates](https://pkg.pr.new/template/086d445d-f1a3-4511-ba26-33294c79fa47) - [@tanstack/query-example-svelte-load-more-infinite-scroll](https://pkg.pr.new/template/80e8a2e3-b708-4aea-ba49-31309a0b07ea) - [@tanstack/query-example-svelte-playground](https://pkg.pr.new/template/a8284cdf-ffee-4e9c-aa01-2aebad3114e0) - [@tanstack/query-example-svelte-simple](https://pkg.pr.new/template/cdbc0f36-ec9d-48d9-8174-6f614287c275) - [@tanstack/query-example-svelte-ssr](https://pkg.pr.new/template/c9f3fd4d-8970-4117-8fed-d0f23803336f) - [@tanstack/query-example-svelte-star-wars](https://pkg.pr.new/template/f3c37c15-725a-408d-b0c5-9cb1aa34fac4) - [@tanstack/query-example-vue-2.6-basic](https://pkg.pr.new/template/5b60d7c2-497d-48ab-9768-8dd4fc38ff17) - [@tanstack/query-example-vue-2.7-basic](https://pkg.pr.new/template/596b8164-f4e1-4c30-b07b-abe9ad3c2e22) - [@tanstack/query-example-vue-basic](https://pkg.pr.new/template/d79993dc-81b8-4ee3-b2a2-5af0ae24ad70) - [@tanstack/query-example-vue-nuxt3](https://pkg.pr.new/template/c91e18f8-6153-4a38-8d35-7f35fb3d962a) - [@tanstack/query-example-vue-dependent-queries](https://pkg.pr.new/template/22ac7772-cf33-4c00-805f-fe0e6d3df2dc) - [@tanstack/query-example-vue-persister](https://pkg.pr.new/template/7495f9f9-8562-4647-86f6-dd6c2deaac8b) - [@tanstack/query-example-vue-simple](https://pkg.pr.new/template/1eefc3dc-78ee-4d5e-b3b7-da5e5e389620)

@tanstack/angular-query-devtools-experimental

``` pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8151 ```

@tanstack/eslint-plugin-query

``` pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8151 ```

@tanstack/angular-query-experimental

``` pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8151 ```

@tanstack/query-async-storage-persister

``` pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8151 ```

@tanstack/query-broadcast-client-experimental

``` pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8151 ```

@tanstack/query-core

``` pnpm add https://pkg.pr.new/@tanstack/query-core@8151 ```

@tanstack/query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/query-devtools@8151 ```

@tanstack/query-persist-client-core

``` pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8151 ```

@tanstack/query-sync-storage-persister

``` pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8151 ```

@tanstack/react-query

``` pnpm add https://pkg.pr.new/@tanstack/react-query@8151 ```

@tanstack/react-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8151 ```

@tanstack/react-query-next-experimental

``` pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8151 ```

@tanstack/react-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8151 ```

@tanstack/solid-query

``` pnpm add https://pkg.pr.new/@tanstack/solid-query@8151 ```

@tanstack/solid-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8151 ```

@tanstack/solid-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8151 ```

@tanstack/svelte-query

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query@8151 ```

@tanstack/svelte-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8151 ```

@tanstack/svelte-query-persist-client

``` pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8151 ```

@tanstack/vue-query

``` pnpm add https://pkg.pr.new/@tanstack/vue-query@8151 ```

@tanstack/vue-query-devtools

``` pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8151 ```

commit: 81ff334

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.89%. Comparing base (2fe16e5) to head (81ff334). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/TanStack/query/pull/8151/graphs/tree.svg?width=650&height=150&src=pr&token=jqEbswkEDQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack)](https://app.codecov.io/gh/TanStack/query/pull/8151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) ```diff @@ Coverage Diff @@ ## main #8151 +/- ## =========================================== + Coverage 45.41% 81.89% +36.48% =========================================== Files 200 26 -174 Lines 7456 359 -7097 Branches 1696 98 -1598 =========================================== - Hits 3386 294 -3092 + Misses 3694 56 -3638 + Partials 376 9 -367 ``` | [Components](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | Coverage Δ | | |---|---|---| | [@tanstack/angular-query-devtools-experimental](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/angular-query-experimental](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/eslint-plugin-query](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/query-async-storage-persister](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/query-broadcast-client-experimental](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/query-codemods](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/query-core](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/query-persist-client-core](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/query-sync-storage-persister](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/react-query](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `93.12% <100.00%> (ø)` | | | [@tanstack/react-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `10.00% <ø> (ø)` | | | [@tanstack/react-query-next-experimental](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/react-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `100.00% <ø> (ø)` | | | [@tanstack/solid-query](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/solid-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/solid-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/svelte-query](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/svelte-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/svelte-query-persist-client](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/vue-query](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | | | [@tanstack/vue-query-devtools](https://app.codecov.io/gh/TanStack/query/pull/8151/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TanStack) | `∅ <ø> (∅)` | |