bad types in file link.d.ts

[livwvil]

Describe the bug

There is wrong types in link.d.ts:

...
export declare function createLink<const TComp>(Comp: TComp): LinkComponent<TComp>;
...

My ts says: ERROR(TypeScript) Declaration or statement expected.

Your Example Website or App

nope

Steps to Reproduce the Bug or Issue

1. Get "@tanstack/react-router": "^1.20.5" in your project
2. Try to run project

Expected behavior

No errors displayed

Screenshots or Videos

No response

Platform

• OS: Windows
• Browser: Chrome
• Version: 122
• @tanstack/react-router: "^1.20.5"
• typescript: "^4.9.5"

Additional context

I have no this errors on "@tanstack/react-router": "^1.19.1"

[schiller-manuel]

which typescript version are you using?

[livwvil]

Just updated: "typescript": "^4.9.5"

[livwvil]

I think that's the whole point. According to playground TS 4.9.5 does not support the const keyword Should we count on backward compatibility?

[GutsSOLO]

my bad effectively I got the error because of a compiler which was compiling in typescript 4.7.4 If you update with 5.x.x the error disappear but it would be great this was stated

[TkDodo]

I think we should just state that the minimal required TS version is v5.0

[livwvil]

I think we should just state that the minimal required TS version is v5.0

Do you think it is the only way?

[TkDodo]

Yes

[TkDodo]

docs are updated with:

• https://github.com/TanStack/router/pull/1367

[GutsSOLO]

I think we should just state that the minimal required TS version is v5.0

Do you think it is the only way?

another solution would be : export declare function createLink(Comp: TComp): TComp;

[TkDodo]

We only want to support TS 5.0 and upwards for other reasons too

[GutsSOLO]

For those who may need there is a patch file if you're working under typescript < 5.x.x

` diff --git a/node_modules/@tanstack/react-router/dist/esm/link.d.ts b/node_modules/@tanstack/react-router/dist/esm/link.d.ts index b523933..b9113bd 100644 --- a/node_modules/@tanstack/react-router/dist/esm/link.d.ts +++ b/node_modules/@tanstack/react-router/dist/esm/link.d.ts @@ -91,6 +91,6 @@ type LinkComponent = <TRouteTree extends AnyRoute = RegisteredRouter['rou }> | React.Component<{ ref: infer TRef; }> ? TRef : TComp extends keyof JSX.IntrinsicElements ? React.ComponentRef : never>) => React.ReactElement; -export declare function createLink(Comp: TComp): LinkComponent; +export declare function createLink(Comp: TComp): TComp; export declare const Link: LinkComponent<'a'>; export {}; @tanstack+react-router+1.22.7.patch

`