search

TanStack / router

🤖 Fully typesafe Router for React (and friends) w/ built-in caching, 1st class search-param APIs, client-side cache integration and isomorphic rendering.
https://tanstack.com/router
MIT License
7.19k stars 486 forks source link

Uncaught Error #1513

Closed andelkocvjetkovic closed 1 week ago

andelkocvjetkovic commented 3 weeks ago

Describe the bug

When an error is thrown within the loader, "Uncaught Error" appears in my browser console, even though the error page is shown.

Your Example Website or App

https://stackblitz.com/edit/tanstack-router-zz3epc?file=src%2Fposts.tsx

Steps to Reproduce the Bug or Issue

  1. Click on Post 1.
  2. Open browser console and observe "Uncaught Error" 
    chunk-WM253HRZ.js?v=5f883516:1114 Uncaught Error at posts.tsx:15:20

Expected behavior

I expect to the error within loader to be caught and clean console in my browser

Screenshots or Videos

Screenshot 2024-04-24 at 11 25 34

Platform

Additional context

No response

hugocostadev commented 3 weeks ago

check this issue, maybe it's the same...

https://github.com/TanStack/router/issues/1480

andelkocvjetkovic commented 3 weeks ago

I'm on "@tanstack/react-router": "1.28.1", so I don't think it is related

andelkocvjetkovic commented 3 weeks ago

The issue is present in "@tanstack/react-router": "1.31.1" as well

SeanCassiere commented 2 weeks ago

A couple of questions:

  1. Just to be clear, the issue here is that we are logging the error to the console?
  2. Why is logging the error to the console bad?

It's important to remember that this is client-sided, so there's no chance of SECRETS being revealed. Also, you'll only ever get here when there has been an error and the errorComponent has been triggered, and by default,errors are always printed to the console.

We'd need a valid reason to change this behaviour since some users have hooks that use the output of the console and that this isn't a show-stopping problem or a bug. Its currently, the intended behaviour.

andelkocvjetkovic commented 1 week ago

My question is why I'm getting an 'Uncaught Error' in my console. Is this something I should take care of, and how precisely should I handle this?

Thanks.

SeanCassiere commented 1 week ago

@andelkocvjetkovic this isn't something that requires intervention from you. No further error handling is required on your-part.

Very simply, the Error is printed out to the console since the application has encountered an error (intentional or not). You can choose to customize how you display the Error to the user using the errorComponent, but nevertheless an Error has occurred. As such, the error is printed to the console.