search

TanStack / router

🤖 Fully typesafe Router for React (and friends) w/ built-in caching, 1st class search-param APIs, client-side cache integration and isomorphic rendering.
https://tanstack.com/router
MIT License
7.19k stars 486 forks source link

fix(react-router): encoding of `/` in path parameters #1520

Closed SeanCassiere closed 3 weeks ago

SeanCassiere commented 3 weeks ago

Closes #1515

The main change is that path parameters are now encoded using encodeURIComponent function instead of encodeURI so characters like a "/" are correctly encoded.

The splat route, however, still uses the encodeURI function since it needs to retain the "/" characters.

nx-cloud[bot] commented 3 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1d3afe061f776eacb9dbdf379570c76c31a8e3e1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets - [`nx affected --targets=test:format,test:eslint,test:unit,test:build,build --parallel=3`](https://cloud.nx.app/runs/pyjemSB3bk?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test:types --exclude=examples/**`](https://cloud.nx.app/runs/MFxrdNhwwy?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.