Can't override defaultViewTransition - Githubissues

TanStack / router

🤖 Fully typesafe Router for React (and friends) w/ built-in caching, 1st class search-param APIs, client-side cache integration and isomorphic rendering.

https://tanstack.com/router

MIT License

7.19k stars 486 forks source link

Can't override defaultViewTransition #1526

Closed ceski23 closed 2 weeks ago

ceski23 commented 3 weeks ago

Describe the bug

After configuring router with defaultViewTransition: true, using navigate or Link with viewTransition: false doesn't disable transition

Your Example Website or App

https://stackblitz.com/edit/github-g4ctdl?file=src%2Fmain.tsx

Steps to Reproduce the Bug or Issue

Click About link, route change is transitioned correctly
Click Home link, route change is transitioned but shouldn't

Expected behavior

Using Link or navigate with viewTransition: false should override defaultViewTransition and disable transition when changing route

Screenshots or Videos

No response

Platform

OS: Windows 11 (WSL)
Browser: Microsoft Edge
Version: 123

Additional context

No response

SeanCassiere commented 2 weeks ago

This has been fixed and published in the 1.31.6 release.