search

TanStack / router

🤖 Fully typesafe Router for React (and friends) w/ built-in caching, 1st class search-param APIs, client-side cache integration and isomorphic rendering.
https://tanstack.com/router
MIT License
7.19k stars 486 forks source link

fix(react-router): when navigating without `to` the layout segments are not being stripped out #1561

Closed SeanCassiere closed 2 weeks ago

SeanCassiere commented 2 weeks ago

1548 didn't account for layout routes as pointed out in #1560.

FIxes #1560

nx-cloud[bot] commented 2 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ac44017d1982d2e9079db1a341a50b333004c955. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets - [`nx affected --targets=test:format,test:eslint,test:unit,test:build,build --parallel=3`](https://cloud.nx.app/runs/N18uxrBwg2?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test:types --exclude=examples/**`](https://cloud.nx.app/runs/a7H4lXDhPh?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

schiller-manuel commented 2 weeks ago

LGTM, if you add the test we can merge

SeanCassiere commented 2 weeks ago

LGTM, if you add the test we can merge

Yup, I started with the tests. I guess now I'm a TDD guy 😬

SeanCassiere commented 2 weeks ago

Actually I'll add a test for the util as well before merge

Edit: The review comment didn't show up when reading on mobile.