search

TanStack / router

🤖 Fully typesafe Router for React (and friends) w/ built-in caching, 1st class search-param APIs, client-side cache integration and isomorphic rendering.
https://tanstack.com/router
MIT License
7.87k stars 586 forks source link

loader doesn't run after redirects #1777

Closed bagindo closed 2 months ago

bagindo commented 3 months ago

Describe the bug

using the latest version, the loader with loaderDeps doesn't run initially.

the page needs to be reloaded for it to run.

Reproduction on version ^1.20.4 (✅ works fine) https://stackblitz.com/edit/github-p2w83v-xh9id6

Reproduction on the latest version (^1.38.1) (❌ doesn't run initially) https://stackblitz.com/edit/github-p2w83v-pz6euc

Your Example Website or App

https://stackblitz.com/edit/github-p2w83v-pz6euc

Steps to Reproduce the Bug or Issue

update to the latest version

Expected behavior

run initially, without having to reload the page.

Screenshots or Videos

No response

Platform

Additional context

No response

bagindo commented 3 months ago

Hi @SeanCassiere I tracked down in which version this has stopped working.

It's v1.36.3 on #1713 PR, in which the loader is not called after redirection. What's the reason behind this?

I have a one page app, and I just want to redirect from the /index route to another route /esp with the today's date as the search param.

Here's the minimal reproduction: v 1.36.2 (✅ works) v 1.36.3 (❌ undefined initially - but if the page is reloaded it works)

I wrapped the app with React.StrictMode. If I removed the React.StrictMode wrapper, it does work on both versions.

schiller-manuel commented 2 months ago

this will be fixed by #1907

reproducer with pre-release package: https://stackblitz.com/edit/github-p2w83v-f2pkuk?file=package.json