TanStack / router

🤖 Fully typesafe Router for React (and friends) w/ built-in caching, 1st class search-param APIs, client-side cache integration and isomorphic rendering.
https://tanstack.com/router
MIT License
8.14k stars 634 forks source link

[Start]: $RefreshSig$ is not a function #2179

Open omarkhatibco opened 2 months ago

omarkhatibco commented 2 months ago

Describe the bug

This might not be a bug related to the start directly, but somehow it works fine in vite directly.

the problem that some file is not compliant with fast refresh and therefore it invalidates

it breaks in the start starter but works fine in vite.

check the repository for a reproduction

Your Example Website or App

https://github.com/omarkhatibco/start-test

Steps to Reproduce the Bug or Issue

run bun install and then bun dev check both urls http://localhost:3000/ & http://localhost:5174/ you can see that start url is failing.

Expected behavior

it should work fine

Screenshots or Videos

No response

Platform

Additional context

No response

SeanCassiere commented 2 months ago

Trying this out, I'm not getting any errors thrown in either "app" in the client or the server.

Following the reproduction steps, I ran the bun dev command and had both URLs opened. In each project, I made a change and observed the following.

@tannerlinsley is this expected behaviour (given that this is SSR)?

SeanCassiere commented 2 months ago

Speaking with Tanner, the HMR not replacing the modules and instead performing a full reload is indeed a bug.

omarkhatibco commented 2 months ago

@SeanCassiere btw, I discovered that if you update something inside the monorepo library, the dev server will crash