search

TanStack / table

🤖 Headless UI for building powerful tables & datagrids for TS/JS - React-Table, Vue-Table, Solid-Table, Svelte-Table
https://tanstack.com/table
MIT License
25.24k stars 3.08k forks source link

After v7s Release, v6 is looking for v7's css #1678

Closed hollygirouard closed 4 years ago

hollygirouard commented 4 years ago

Using v6?

v6 is now considered feature complete to its current abilities and limitations. We are not actively working to fix any issues for v6 any more. We will, however, merge any non-breaking pull requests submitted to fix anything in v6.

Using v7?

Thanks for using the beta version of React Table v7! We're very excited about it.

Describe the bug Using "react-table": "^6.10.3", I did try changing it to "react-table": "6.10.3", and no dice there either GET https://unpkg.com/react-table@7.0.0-beta.21/react-table.css net::ERR_ABORTED 404

To Reproduce Steps to reproduce the behavior:

  1. Go to '.https://www.doingthingsmedia.com/dashboard'
  2. Click on 'Inspect Element'
  3. Check out the console.
  4. See error

Expected behavior v6 should not be looking for v7's css

Codesandbox! Use a new react-table codesandbox to reproduce the issue.

Screenshots https://dtm-app-test.s3.us-east-2.amazonaws.com/Screen+Shot+2019-12-02+at+10.54.03+AM.png

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

cc9431 commented 4 years ago

Also having this problem. Error in console leads to a link displaying: "Cannot find "/react-table.css" in react-table@7.0.0-beta.21"

jacobselg commented 4 years ago

Yeah, I'm seeing this issue as well in production code, returning 404 on https://unpkg.com/react-table@7.0.0-beta.21/react-table.css

burhanbvk commented 4 years ago

This is an issue with the css included in the index.html file. The latest version no longer has the css file, so you need to specify the version in the stylesheet url.

It is the public/index.html file

<link rel="stylesheet" href="https://unpkg.com/react-table@latest/react-table.css">

This is in there, pointing to the latest release, which no longer seems to have the css file Change it to: <link rel="stylesheet" href="https://unpkg.com/react-table@6.10.3/react-table.css">

tannerlinsley commented 4 years ago

Yep, v7 no longer comes with css (the examples have the bare minimum to get you to a working table with decent layout.

If you are still using v6, you should be locking your version to the ^6 tag at the very least and not the @latest tag.