TanStack / table

🤖 Headless UI for building powerful tables & datagrids for TS/JS - React-Table, Vue-Table, Solid-Table, Svelte-Table
https://tanstack.com/table
MIT License
25.03k stars 3.07k forks source link

feat: add isDesc to sortingFn #5411

Closed tychenjiajun closed 6 months ago

tychenjiajun commented 6 months ago

See https://github.com/TanStack/table/discussions/2371

nx-cloud[bot] commented 6 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6429495196df5361b66771eab65421982066f95a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3
✅ Successfully ran 1 target - [`nx run-many --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3`](https://cloud.nx.app/runs/W0VJiO3iAp?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

KevinVandy commented 6 months ago

invertSorting as a column option already exists. https://tanstack.com/table/latest/docs/guide/sorting#sorting-direction

sortUndefined as a column option already exists. https://tanstack.com/table/latest/docs/guide/sorting#sort-undefined-or-nullish-values

I do not see any of these changes as necessary.

tychenjiajun commented 6 months ago

What about https://github.com/TanStack/table/discussions/2371#discussioncomment-7379762 ? I still can't force null or empty values to bottom when sorting using sortUndefined and/or invertSorting, see Edit compassionate-matan-ltcq34