TanStack / table

🤖 Headless UI for building powerful tables & datagrids for TS/JS - React-Table, Vue-Table, Solid-Table, Svelte-Table
https://tanstack.com/table
MIT License
24.61k stars 3.04k forks source link

chore: split filtering features and rename #5413

Closed KevinVandy closed 4 months ago

nx-cloud[bot] commented 4 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 70bf907a4707f99dd5be6245a1a021272817916e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3`](https://cloud.nx.app/runs/035eHeVsBy?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

matthawk60 commented 4 months ago

There are a bunch of examples that use FiltersTableState as a type. This completely breaks that.
I'd be more than happy to help contribute If I could get some information on why the filters were split in the first place. I have just added them back to the global types for now.

import '@tanstack/react-table'
import { ColumnMeta, ColumnFiltersState } from '@tanstack/table-core'

declare module '@tanstack/table-core' {
    interface ColumnMeta<TData extends RowData, TValue> {
        className?: string;
        headerClassName?: string;
        bodyClassName?: string;
        mobileClassName?: string;
        size?: number | 'auto';
        title?: string;
    }
    interface FiltersTableState {
        columnFilters: ColumnFiltersState;
        globalFilter: any;
    }
}