TanStack / table

🤖 Headless UI for building powerful tables & datagrids for TS/JS - React-Table, Vue-Table, Solid-Table, Svelte-Table
https://tanstack.com/table
MIT License
25.01k stars 3.07k forks source link

feat: new sortUndefined last and first options #5486

Closed KevinVandy closed 5 months ago

KevinVandy commented 5 months ago

This pr gives new "official" options to force undefined column values to either the bottom or top rows of a table when a sort is performed on those columns when the sortUndefined is set to 'last' or 'first' in the column option.

This used to be behavior out of the box with sortUndefined: 1, but was changed 10 months ago to not count undefined values. This PR will not have any breaking changes, but will allow those who preferred the old behavior more with an explicit option.

nx-cloud[bot] commented 5 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7e965ecdf7b11e3478fe4cbb1d95b0f27c1f8e29. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3`](https://cloud.nx.app/runs/axu4jKkMbs?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.