search

TanStack / table

🤖 Headless UI for building powerful tables & datagrids for TS/JS - React-Table, Vue-Table, Solid-Table, Svelte-Table
https://tanstack.com/table
MIT License
24.51k stars 3.03k forks source link

fix: getIsSomeRowsSelected on all selection #5499

Open iamswain25 opened 2 months ago

iamswain25 commented 2 months ago

Selecting all rows and run getIsSomeRowsSelected, it return false instead of true.

sijonelis commented 3 weeks ago

Is it possible to get this merged? The documentation already states that this is how the row selection check should work!

KevinVandy commented 1 week ago

To truly fix this I think some breaking changes might be needed. I'm going to point this PR to the alpha branch probably

nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a0f1cc3f26ae4e2debf215bebd9fe9046c34cfee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target - [`nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3`](https://cloud.nx.app/runs/VWqXDw5ltH?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.