TanStack / table

🤖 Headless UI for building powerful tables & datagrids for TS/JS - React-Table, Vue-Table, Solid-Table, Svelte-Table
https://tanstack.com/table
MIT License
24.51k stars 3.03k forks source link

fix(angular-table): handle null and number values with flex-render #5550

Closed riccardoperra closed 1 month ago

riccardoperra commented 1 month ago

@KevinVandy grouping example was broken due to flexRenderDirective not handling null content (e.g. when a cell is grouped)

Screenshot 2024-05-13 alle 08 47 41

Here a screenshot of the grouping example after the fix

nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b61063d89a64a2162502e73da70634d1c052b18. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3`](https://cloud.nx.app/runs/YD1o13UWOf?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

jrgokavalsa commented 1 month ago

@riccardoperra, I've observed an issue where the aggregatedCell function is not operating correctly in conjunction with age data. Upon debugging, I found that if aggregatedCell returns a number, no values are displayed. However, when it returns a string, it functions as expected. This behavior suggests that there might be a type-related discrepancy within the renderContent function's.

riccardoperra commented 1 month ago

@jrgokavalsa Thanks I've forgot it. I've added a new check in order to support both string and numbers