search

TanStack / table

🤖 Headless UI for building powerful tables & datagrids for TS/JS - React-Table, Vue-Table, Solid-Table, Svelte-Table
https://tanstack.com/table
MIT License
24.51k stars 3.03k forks source link

fix: Add a missing guard for 'undefined' in the getFilteredRowModel function. #5555

Closed jjh2613 closed 1 month ago

jjh2613 commented 1 month ago

Hi,

I had a small issue with GlobalFilter while trying to use filter values with the createTable function. I encountered a problem related to an undefined value in getFilteredRowModel

I found a missing undefined guard in getFilteredRowModel.ts. There is another guard (with starting semicolon?) in the same function

https://github.com/TanStack/table/blob/047348f2f6ccb180e568f80ce5dd84b3087d630f/packages/table-core/src/utils/getFilteredRowModel.ts#L31

but it was missing in the section I committed.

After committing this change, everything works fine for me now.

P.S. Thanks for the awesome project. I am really enjoying TanStack Table.

nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 96a50bb3394c651b9cd47ebc432315ec0004c5de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets - [`nx affected --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3`](https://cloud.nx.app/runs/c7PXil0XzT?utm_source=pull-request&utm_medium=comment) - [`nx run-many --targets=test:format,test:sherif,test:knip,test:lib,test:types,build --parallel=3`](https://cloud.nx.app/runs/HrrnSFGQUX?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.