Closed riccardoperra closed 6 days ago
CI is running/has finished running commands for commit f03fd09e610e69afb7cc0904ea5379d620fd05bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
While using Angular table adapter in our application, we discovered an issue with FlexRenderDirective that prevents the content from being shown if the cell renders a
null | undefined
value the first time.Use case:
data
with the same cell valuated (e.g. after the user does an update operation)The issue is related to the current rendering mechanism, which is invoked inside the
ngOnInit
hook (one-time, only after Angular initialized all the inputs).I moved the logic inside ngOnChanges, so that everything is invoked whenever the inputs change. I had to update some test according to this fix, so I moved the first two check about null | undefined in order to be sure that the content is reactive and always rendered (except for null | undefined)
Since we are using ngOnChanges, we don't need anymore to call the markForCheck while rendering a Component or TemplateRef inside the ngDoCheck