Cannot change Framework or Version in the selectors.

DogPawHat commented 2 weeks ago

Steps

Try to select a new version or framework on tanstack.com/query from the framework/version selector:

Expected Behaviour

You should navigate to the docs for the selected framework/version (eg /query/latest/docs/framework/react -> /query/v3/docs/framework/react

Actual behaviour

No navigation occurs and the selector remains stuck.

Nodes

Installed the site locallaly and ran a bisect section to track down the issue:

 git bisect good
42a83f39c496cd9197bbe3733c77194bc59bc598 is the first bad commit
commit 42a83f39c496cd9197bbe3733c77194bc59bc598
Author: Tanner Linsley <tannerlinsley@gmail.com>
Date:   Mon Apr 29 23:37:24 2024 -0600

    fix: upgrades

 app/components/DocsLayout.tsx            |   6 +-
 app/images/people/dominikdorfmeister.jpg | Bin 0 -> 84778 bytes
 app/images/people/kevinvancott.jpeg      | Bin 0 -> 125932 bytes
 app/images/people/tannerlinsley.jpeg     | Bin 0 -> 110884 bytes
 app/routeTree.gen.ts                     |  31 +-
 app/routes/_libraries.index.tsx          | 531 +++++++++++++++++++++++++++
 app/routes/_libraries.support.tsx        | 152 ++++++++
 app/routes/_libraries.tsx                |  77 ++--
 app/routes/index.tsx                     | 591 -------------------------------
 media/brand.sketch                       | Bin 861477 -> 882244 bytes
 package.json                             |   6 +-
 pnpm-lock.yaml                           | 514 ++++++++++++++++++---------
 12 files changed, 1113 insertions(+), 795 deletions(-)
 create mode 100644 app/images/people/dominikdorfmeister.jpg
 create mode 100644 app/images/people/kevinvancott.jpeg
 create mode 100644 app/images/people/tannerlinsley.jpeg
 create mode 100644 app/routes/_libraries.index.tsx
 create mode 100644 app/routes/_libraries.support.tsx
 delete mode 100644 app/routes/index.tsx

At 42a83f39c496cd9197bbe3733c77194bc59bc598, I suspect the @tanstack/react-router": upgrade from 1.29.2 to 1.31.3 is responsible and there's an issue in that version.

DogPawHat commented 2 weeks ago

Issue seems to have been introduced in https://github.com/TanStack/router/commit/91bf1bc42a73da9da59f8ff16eb26a9840893136 . This is probably not isolated to the TanstackSite itself.

DogPawHat commented 2 weeks ago

Fixed in https://github.com/TanStack/tanstack.com/commit/35448e1239ee33b315ff018937e0c5dc6dd426ca

TanStack / tanstack.com