TanStack / virtual

🤖 Headless UI for Virtualizing Large Element Lists in JS/TS, React, Solid, Vue and Svelte
https://tanstack.com/virtual
MIT License
5.38k stars 291 forks source link

Example with react-table v8? #433

Closed MarksCode closed 1 year ago

MarksCode commented 1 year ago

Describe the bug

I see there's a demo for react-table v8 with react-window v2, but I don't see one using v3 anywhere. Does anyone know if the 2 libraries work together?

Your minimal, reproducible example

https://codesandbox.io/s/github/tanstack/table/tree/main/examples/react/virtualized-rows?from-embed=&file=/src/main.tsx:3975-4024

Steps to reproduce

N/A

Expected behavior

N/A

How often does this bug happen?

No response

Screenshots or Videos

No response

Platform

Mac/Windows

tanstack-virtual version

v3

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct

suparerkk commented 1 year ago

Yes, I can confirm it is working with react-table v8 https://codesandbox.io/s/example-with-react-table-v8-v95utd

I'm just forked from https://codesandbox.io/s/github/tanstack/table/tree/main/examples/react/virtualized-rows?from-embed=&file=/src/main.tsx:3975-4024 and made changes a few lines

Zertz commented 1 year ago

FWIW, the example above crashes when I scroll to the bottom of the table:

image

canastro commented 1 year ago

@Zertz were you able to figure out whats wrong with this sandbox?