search

TanStack / virtual

🤖 Headless UI for Virtualizing Large Element Lists in JS/TS, React, Solid, Vue and Svelte
https://tanstack.com/virtual
MIT License
5.55k stars 303 forks source link

fix(angular-virtual): fix build & remove unused scripts #807

Closed garrettld closed 2 months ago

garrettld commented 3 months ago

Excluding .d.ts files from the package output results in TypeScript errors for consumers trying to install @tanstack/angular-virtual.

For example:

image

(from https://tanstack.com/virtual/latest/docs/framework/angular/examples/fixed)

This was a simple copy/paste error that I only noticed after the package was published, since the .d.ts files are present locally and only get excluded by the actual npm publish.

pkg-pr-new[bot] commented 3 months ago

commit: 6c06a57

@tanstack/angular-virtual

``` pnpm add https://pkg.pr.new/@tanstack/angular-virtual@807 ```

@tanstack/lit-virtual

``` pnpm add https://pkg.pr.new/@tanstack/lit-virtual@807 ```

@tanstack/react-virtual

``` pnpm add https://pkg.pr.new/@tanstack/react-virtual@807 ```

@tanstack/solid-virtual

``` pnpm add https://pkg.pr.new/@tanstack/solid-virtual@807 ```

@tanstack/svelte-virtual

``` pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@807 ```

@tanstack/virtual-core

``` pnpm add https://pkg.pr.new/@tanstack/virtual-core@807 ```

@tanstack/vue-virtual

``` pnpm add https://pkg.pr.new/@tanstack/vue-virtual@807 ```

Open in Stackblitz

More templates

- [@tanstack/virtual-example-angular-dynamic](https://pkg.pr.new/template/f015abaa-5e58-4f56-95cb-81b31bc4e101) - [@tanstack/virtual-example-angular-fixed](https://pkg.pr.new/template/24decf86-bd30-4e3c-92e5-68bc8f1dcdf7) - [@tanstack/virtual-example-angular-infinite-scroll](https://pkg.pr.new/template/a2146913-894c-421a-90c2-3e4caf1e168d) - [@tanstack/virtual-example-angular-padding](https://pkg.pr.new/template/01c99fb7-b433-49af-836c-69532f84db88) - [@tanstack/virtual-example-angular-smooth-scroll](https://pkg.pr.new/template/f383c94b-c4ff-47a4-8704-4a3b92e56075) - [@tanstack/virtual-example-angular-sticky](https://pkg.pr.new/template/7a848059-f270-424e-94b8-965b1ac1b8e0) - [@tanstack/virtual-example-angular-table](https://pkg.pr.new/template/670c1a86-ad10-48a5-a4cc-d8c94e195731) - [@tanstack/virtual-example-angular-variable](https://pkg.pr.new/template/d1fd7fb9-fc26-452d-a890-e77327f08c7f) - [@tanstack/virtual-example-angular-window](https://pkg.pr.new/template/e1d8d6cb-85a4-4a98-b3db-bcdfcedb2bf9) - [tanstack-lit-virtual-example-dynamic](https://pkg.pr.new/template/52ab505d-033e-4d06-b95e-7388c9386f89) - [tanstack-lit-virtual-example-fixed](https://pkg.pr.new/template/1459f5c6-d153-41a9-8e29-874d1294bbe2) - [tanstack-react-virtual-example-dynamic](https://pkg.pr.new/template/14d63102-95fb-4a35-9b4d-4ca039005f2d) - [tanstack-react-virtual-example-fixed](https://pkg.pr.new/template/8e8fd29d-2466-4dde-942b-69ef32f15728) - [tanstack-react-virtual-example-infinite-scroll](https://pkg.pr.new/template/e7383498-8efb-46e8-a43c-c749f01b8364) - [tanstack-react-virtual-example-padding](https://pkg.pr.new/template/94cba354-8037-4044-a15e-509c757bf74c) - [tanstack-react-virtual-example-scroll-padding](https://pkg.pr.new/template/a531bb56-4792-436f-a17c-029d0b939d88) - [tanstack-react-virtual-example-smooth-scroll](https://pkg.pr.new/template/ed1775e9-800f-48dd-a076-967974e60a2d) - [tanstack-react-virtual-example-sticky](https://pkg.pr.new/template/36a5e017-8301-4ed3-a001-fa0d8bc90fc4) - [tanstack-react-virtual-example-table](https://pkg.pr.new/template/1ca5526d-1850-458c-82f7-85bb2511406e) - [tanstack-react-virtual-example-variable](https://pkg.pr.new/template/216b8d12-90e2-4019-9131-7ffd0376c309) - [tanstack-react-virtual-example-window](https://pkg.pr.new/template/50cb12b0-af45-4430-95c8-1b01934ab612) - [tanstack-svelte-virtual-example-dynamic](https://pkg.pr.new/template/6763b713-af46-4609-a00f-8974970f5f80) - [tanstack-svelte-virtual-example-fixed](https://pkg.pr.new/template/8611d28c-16bc-4b36-abfc-417bfe69596e) - [tanstack-svelte-virtual-example-infinite-scroll](https://pkg.pr.new/template/407579b0-9559-4c1b-b7db-08d73c7e462d) - [tanstack-svelte-virtual-example-smooth-scroll](https://pkg.pr.new/template/05fffecb-8e11-4d43-8aea-88619c2ac02f) - [tanstack-svelte-virtual-example-sticky](https://pkg.pr.new/template/bdbd9f50-a697-41ce-9472-bdd4745708b3) - [tanstack-svelte-virtual-example-table](https://pkg.pr.new/template/6e186864-9400-4906-8c59-b1325191a20d) - [tanstack-vue-virtual-example-dynamic](https://pkg.pr.new/template/7c618d78-0bb3-49c0-a3cb-bb38ef6ca128) - [tanstack-vue-virtual-example-fixed](https://pkg.pr.new/template/28506853-3f16-48d4-a8c6-a2959783554a) - [tanstack-vue-virtual-example-infinite-scroll](https://pkg.pr.new/template/d864c2d5-bce4-4b38-abad-e3a8b0d729e3) - [tanstack-vue-virtual-example-padding](https://pkg.pr.new/template/5f760e09-6afd-4c91-874a-ac45092331a8) - [tanstack-vue-virtual-example-scroll-padding](https://pkg.pr.new/template/396b84a9-4b79-4dcc-8dac-01d8379235be) - [tanstack-vue-virtual-example-smooth-scroll](https://pkg.pr.new/template/97ed07a4-7f75-4969-bf6e-5480d1558eeb) - [tanstack-vue-virtual-example-sticky](https://pkg.pr.new/template/32f7da3d-7984-4988-b1b7-95ee5a37eab2) - [tanstack-vue-virtual-example-table](https://pkg.pr.new/template/3b1668e5-6405-406e-91fc-841e15ce18b5) - [tanstack-vue-virtual-example-variable](https://pkg.pr.new/template/11324619-3322-470d-8c07-7659dd370258)

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6c06a572975962840da91efc5039ba0f00b3e1c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets - [`nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build`](https://cloud.nx.app/runs/68ANWw7AnD?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --exclude=examples/**`](https://cloud.nx.app/runs/VZmgnM3Yxd?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.