TanStack / virtual

🤖 Headless UI for Virtualizing Large Element Lists in JS/TS, React, Solid, Vue and Svelte
https://tanstack.com/virtual
MIT License
5.55k stars 303 forks source link

fix(angular-virtual): fix proxying of computed functions with args #812

Closed garrettld closed 2 months ago

garrettld commented 2 months ago

Calls to 'getOffsetForAlignment', getOffsetForIndex', 'getVirtualItemForOffset', and 'indexFromElement' now work as expected instead of erroring with TypeError: fn is not a function.

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 124488cb8dba567037cf85aa8d90417545be80ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets - [`nx run-many --target=build --exclude=examples/**`](https://cloud.nx.app/runs/eDxZSnLakG?utm_source=pull-request&utm_medium=comment) - [`nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build`](https://cloud.nx.app/runs/HGGIbG2u1v?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

pkg-pr-new[bot] commented 2 months ago

commit: 124488c

@tanstack/angular-virtual

``` pnpm add https://pkg.pr.new/@tanstack/angular-virtual@812 ```

@tanstack/lit-virtual

``` pnpm add https://pkg.pr.new/@tanstack/lit-virtual@812 ```

@tanstack/react-virtual

``` pnpm add https://pkg.pr.new/@tanstack/react-virtual@812 ```

@tanstack/solid-virtual

``` pnpm add https://pkg.pr.new/@tanstack/solid-virtual@812 ```

@tanstack/svelte-virtual

``` pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@812 ```

@tanstack/virtual-core

``` pnpm add https://pkg.pr.new/@tanstack/virtual-core@812 ```

@tanstack/vue-virtual

``` pnpm add https://pkg.pr.new/@tanstack/vue-virtual@812 ```

Open in Stackblitz

More templates

- [@tanstack/virtual-example-angular-dynamic](https://pkg.pr.new/template/21c3fd58-7ecf-476c-a3cf-64667703cd80) - [@tanstack/virtual-example-angular-fixed](https://pkg.pr.new/template/87f70077-bdf0-4b53-ab98-30d5d8e3581e) - [@tanstack/virtual-example-angular-infinite-scroll](https://pkg.pr.new/template/3cebd9cf-168e-4519-8dc5-63c5b2750a02) - [@tanstack/virtual-example-angular-padding](https://pkg.pr.new/template/bacd7b42-3ed9-4bd9-bfd9-d650d9916a1f) - [@tanstack/virtual-example-angular-smooth-scroll](https://pkg.pr.new/template/5441e819-1928-4dc2-93c6-025334376224) - [@tanstack/virtual-example-angular-sticky](https://pkg.pr.new/template/aef48edc-db9d-4f05-b947-82cddd0dc788) - [@tanstack/virtual-example-angular-table](https://pkg.pr.new/template/2b99bfc7-c822-4223-a3ba-89f8215f10f8) - [@tanstack/virtual-example-angular-variable](https://pkg.pr.new/template/7f8e8468-3081-4998-b018-6e680251b877) - [@tanstack/virtual-example-angular-window](https://pkg.pr.new/template/d4b5d6ce-45bd-4e04-adca-2cb27ec1efc3) - [tanstack-lit-virtual-example-dynamic](https://pkg.pr.new/template/4fa8038d-75d0-4cbf-a907-b4c4911d39a2) - [tanstack-lit-virtual-example-fixed](https://pkg.pr.new/template/144c10e0-29cb-48fe-9a38-f8da2fe066fe) - [tanstack-react-virtual-example-dynamic](https://pkg.pr.new/template/2ede4067-609b-41b6-b999-d12d3cacbece) - [tanstack-react-virtual-example-fixed](https://pkg.pr.new/template/a892c57f-4835-4cf0-944d-e0d1794f7604) - [tanstack-react-virtual-example-infinite-scroll](https://pkg.pr.new/template/71e633a3-1b7f-4737-acf2-3ec6a89faab2) - [tanstack-react-virtual-example-padding](https://pkg.pr.new/template/1e51f8ac-3ee8-4683-8d9c-af860354746e) - [tanstack-react-virtual-example-scroll-padding](https://pkg.pr.new/template/773fc960-8c12-47d2-8eb0-4059257b8cae) - [tanstack-react-virtual-example-smooth-scroll](https://pkg.pr.new/template/c3d0a961-01ff-4120-93fa-22b990def56f) - [tanstack-react-virtual-example-sticky](https://pkg.pr.new/template/973c5d14-b482-451e-a6ac-32c4e4e121c6) - [tanstack-react-virtual-example-table](https://pkg.pr.new/template/92dbd617-5792-4420-aaa2-5a3e4f0305dd) - [tanstack-react-virtual-example-variable](https://pkg.pr.new/template/e5316d07-05fd-4c27-b9f0-3f148f797391) - [tanstack-react-virtual-example-window](https://pkg.pr.new/template/ee41807b-d7e3-4d50-a5f3-712d4e3f47be) - [tanstack-svelte-virtual-example-dynamic](https://pkg.pr.new/template/e45fd7ba-7ad3-43e3-a5df-ffabbac00c47) - [tanstack-svelte-virtual-example-fixed](https://pkg.pr.new/template/974f3a15-bf6d-4c8b-996f-4c893310af2c) - [tanstack-svelte-virtual-example-infinite-scroll](https://pkg.pr.new/template/8aafd643-86fb-4dbb-a63c-87b6d95ee32f) - [tanstack-svelte-virtual-example-smooth-scroll](https://pkg.pr.new/template/827fd1fd-8e98-4981-88e0-9e46312d5d20) - [tanstack-svelte-virtual-example-sticky](https://pkg.pr.new/template/4ca1d170-7b81-4459-807b-3264c5970560) - [tanstack-svelte-virtual-example-table](https://pkg.pr.new/template/58a72bbf-3980-44c1-ae0a-d700976f8b30) - [tanstack-vue-virtual-example-dynamic](https://pkg.pr.new/template/39bb9911-f359-4750-ba93-a0bd763e7d45) - [tanstack-vue-virtual-example-fixed](https://pkg.pr.new/template/1c2bfa45-3d88-43d3-b9ae-2fef1ae98bb6) - [tanstack-vue-virtual-example-infinite-scroll](https://pkg.pr.new/template/8910042a-4435-441b-a173-7f481d343dd4) - [tanstack-vue-virtual-example-padding](https://pkg.pr.new/template/bfd570c4-5e31-47d9-a22c-779c4c9b2364) - [tanstack-vue-virtual-example-scroll-padding](https://pkg.pr.new/template/e9e65f13-5787-4ed1-ab4c-3b3c36750fb7) - [tanstack-vue-virtual-example-smooth-scroll](https://pkg.pr.new/template/42d3e9c2-417a-457e-9a21-042de400e783) - [tanstack-vue-virtual-example-sticky](https://pkg.pr.new/template/b54742d3-22b0-482c-95d5-f45edccab3d7) - [tanstack-vue-virtual-example-table](https://pkg.pr.new/template/715d5afe-9201-4690-b50e-8b19b95f1639) - [tanstack-vue-virtual-example-variable](https://pkg.pr.new/template/0cfe306d-4adc-4a45-a42c-d3cf559d5cf9)