Tanay-ErrorCode / lupo-skill

https://lupo-skill.web.app/
23 stars 73 forks source link

feat: Creating a 404 not found page #257

Closed RamakrushnaBiswal closed 1 week ago

RamakrushnaBiswal commented 1 week ago

Is your feature request related to a problem? Please describe.

image

Describe the solution you'd like we can add some error image and gifs

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Tanay-ErrorCode commented 1 week ago

@RamakrushnaBiswal 404 page is already there as seen in the screenshot.

image


But there is a bug, when going on event details page, if the event id is wrong, only a toast displays for now, but it should show 404 page. Can you fix this?

RamakrushnaBiswal commented 1 week ago

hi @Tanay-ErrorCode we need to add this i guess image https://firebase.google.com/docs/hosting/full-config#404

the configured error page is working for unknown URL but for deploying purpose we need to create another one

Tanay-ErrorCode commented 1 week ago

@RamakrushnaBiswal The application uses HashRouter so if there is wrong URL after the /#/, then it will display the 404 page (image that I provided). This is the current functionality, but if there is something other than # entered by user, it displays that firebase 404 page (image that you provided)

Make 404 page (html one) similar to the current one and fix that event details bug too.

RamakrushnaBiswal commented 1 week ago

image

RamakrushnaBiswal commented 1 week ago

hi @Tanay-ErrorCode we need to change the start url in build directory you can change and check the deploy

Tanay-ErrorCode commented 1 week ago

hi @Tanay-ErrorCode we need to change the start url in build directory you can change and check the deploy

@RamakrushnaBiswal Instead of this, it can be done using this process

RamakrushnaBiswal commented 1 week ago

@Tanay-ErrorCode for this we need to change directory to public

Tanay-ErrorCode commented 1 week ago

@RamakrushnaBiswal There is already a public directory (in which there is index.html), you have to create 404.html there, it will work fine.

RamakrushnaBiswal commented 1 week ago

ok i will create the same design or new one for the page @Tanay-ErrorCode

Tanay-ErrorCode commented 1 week ago

ok i will create the same design or new one for the page @Tanay-ErrorCode

Same.