Tanay-ErrorCode / lupo-skill

https://lupo-skill.web.app/
23 stars 73 forks source link

[Feature] : Navbar mobile site changed #265

Closed sivaprasath2004 closed 5 days ago

sivaprasath2004 commented 1 week ago

Hello @Tanay-ErrorCode , What kind of change does this PR introduce?

[Feature] : Navbar mobile site

Issue Number:

Fixes #258 Snapshots/Videos:

Before

Screenshot from 2024-06-23 08-27-48

After

Screencast from 2024-06-24 09-31-35.webm

Doraemon012 commented 1 week ago

@sivaprasath2004 Do not add icons.

sivaprasath2004 commented 1 week ago

@Doraemon012 please check

Tanay-ErrorCode commented 1 week ago

@sivaprasath2004 Good work but you haven't resolved all the changes.

  1. @sivaprasath2004 Do not add icons.

    Please remove the icons.

  2. The drawer needs to be swipeable

    Your output:

    https://github.com/Tanay-ErrorCode/lupo-skill/assets/90561803/33e59e61-799f-4b18-98d7-52c461b7b354

    We need this:

    https://github.com/Tanay-ErrorCode/lupo-skill/assets/90561803/1950089b-8be1-48a7-b9ad-302346d4d66a

Tanay-ErrorCode commented 1 week ago

@sivaprasath2004 Any updates?

sivaprasath2004 commented 1 week ago

Screencast from 2024-06-27 09-44-30.webm

Hello @Tanay-ErrorCode , i will changed it.

Tanay-ErrorCode commented 5 days ago

@sivaprasath2004 Good work.