Tanay-ErrorCode / lupo-skill

https://lupo-skill.web.app/
23 stars 73 forks source link

Update react-router-dom to version 6 and refactor routing logic #275

Closed MinavKaria closed 1 week ago

MinavKaria commented 1 week ago

Description (Issue #273 )

Updated the react router dom to version 6 with createBrowserRouter

Motivation and Context

It is important to stay updated and version 6 makes the route creation very easy by just adding Also removed the hashrouter where all the links started with #/ which causes which is not good for the SEO.

 {
          path: '/route/:id',
          element: <ElementNeeded/>
 },

Thus making it easier for the beginners to add a page route and made the routes proper for better SEO

How Has This Been Tested?

Checked every route before committing , Fortunately all the routes work properly as previous.

Screenshots (if appropriate):

No visual feature as such so will be need to run on local environment to check the changes

Types of changes

Checklist:

MinavKaria commented 1 week ago

@Doraemon012 @Tanay-ErrorCode why closed ?

Doraemon012 commented 1 week ago

@MinavKaria We didn't close this. You deleted the fork of the repo, which is why the PR closed automatically.

deleted

Doraemon012 commented 1 week ago

@MinavKaria You can see the changes made in this PR in the Files changed tab. To open a PR with the same code, fork the repository again, make the same changes, and then open the PR.

MinavKaria commented 1 week ago

Ohh 😅😅, I'll once again send the PR