search

Tanay-ErrorCode / lupo-skill

https://lupo-skill.web.app/
25 stars 78 forks source link

feat: Update react-router-dom to v6 and Fix Some Issue #299

Closed MinavKaria closed 1 week ago

MinavKaria commented 1 week ago

What kind of change does this PR introduce?

Changed the routing to v6 where all the routes are now present in configs/router.tsx where you need to just add the path and element like 

 {
          path: '/route/:id',
          element: <ElementNeeded/>
 },

Issue Number:

Fixes #273

Main Implementation present in: App.tsx and Navbar.tsx

Other information

Updated the react router dom to version 6 with createBrowserRouter . Finally , making it easier for the beginners to add a page route and made the routes proper for better SEO

MinavKaria commented 1 week ago

@Tanay-ErrorCode Pls acknowledge

MinavKaria commented 1 week ago

@Tanay-ErrorCode @Doraemon012 Why did you revert my PR , everything was fine then too ?

Tanay-ErrorCode commented 1 week ago

@MinavKaria It was working fine on localhost but once deployed on the firebase hosting, it said 404 for all the pages other than the homepage. So I had to revert that.

MinavKaria commented 1 week ago

@Tanay-ErrorCode Ohh, I have heard this for the first time, I have used that method many times and hosted on the firebase too, Maybe firebase.json maybe different that is why it would be showing that 🤔