Tanay-ErrorCode / lupo-skill

https://lupo-skill.web.app/
25 stars 78 forks source link

Articles can we viewed without SignUp #325

Closed devansh-dek closed 1 week ago

devansh-dek commented 1 week ago

What kind of change does this PR introduce? Now users can access all articles without being logged in.

Issue Number: 319

Fixes #319 Snapshots/Videos:

https://github.com/Tanay-ErrorCode/lupo-skill/assets/83805376/5a8a5d9d-857c-4693-8e68-12e9f4e35bd7

Also added a toast telling users to login to view an article or to create an article

Doraemon012 commented 1 week ago

@devansh-dek Good work but some changes are required.

  1. The SignUp modal should not be visible when we open the articles page.
  2. If the user clicks on create article button, and is not logged in, the sign up modal should be shown.
  3. The user should also be able to read articles without being signed in.
  4. There is no need to show toasts.
devansh-dek commented 1 week ago

Okay ill do the necessary changes. Also what to do if someone clicks on article do i have to show him pop too?

Tanay-ErrorCode commented 1 week ago

Okay ill do the necessary changes. Also what to do if someone clicks on article do i have to show him pop too?

@devansh-dek No, the article must be openable and readable without signin.

devansh-dek commented 1 week ago

Here is how it works now

Uploading Lupo Skill - Google Chrome 2024-07-08 13-23-25.mp4…

Doraemon012 commented 1 week ago

Here is how it works now

Uploading Lupo Skill - Google Chrome 2024-07-08 13-23-25.mp4…

@devansh-dek Please upload the screen recording.

devansh-dek commented 1 week ago

here is the recording

https://github.com/Tanay-ErrorCode/lupo-skill/assets/83805376/411a8d17-8f25-452f-bf97-0f44a7374d91