search

Tandem-App-Tuni / Kivako-App

This repository contains the application code.
0 stars 2 forks source link

Feat/alert popup #42

Closed thanh-code-hub closed 4 years ago

petermlakar commented 4 years ago

Why so many updates at once? Also a lot of changes appear to be indentation/space additions. Make sure you outline what you have done in the end, not just changes per line of code.

thanh-code-hub commented 4 years ago

Why so many updates at once? Also a lot of changes appear to be indentation/space additions. Make sure you outline what you have done in the end, not just changes per line of code.

That is my VScode auto formatting code style on save. it seems like there is a lot of inconsistency in coding style and indentation between files. I can disable the formatting off next time if we don't have the need to improve the coding style

petermlakar commented 4 years ago

Why so many updates at once? Also a lot of changes appear to be indentation/space additions. Make sure you outline what you have done in the end, not just changes per line of code.

That is my VScode auto formatting code style on save. it seems like there is a lot of inconsistency in coding style and indentation between files. I can disable the formatting off next time if we don't have the need to improve the coding style

Ok. The issue is that everyone seems to be using a different style. Thusly reviewing different commits becomes tedious since everyone makes some style changes. Then nothing is consistent and harder to read through. But it is too late to change anything. This will be the problem of the next team, so for now lets try to keep the style changes to a minimum so important changes are more exposed.