TandoorRecipes / recipes

Application for managing recipes, planning meals, building shopping lists and much much more!
https://docs.tandoor.dev
Other
5.32k stars 558 forks source link

Multiple Images #1446

Open riker09 opened 2 years ago

riker09 commented 2 years ago

Describe the solution you'd like

I'd like to have more than one image per recipe. On the recipe detail view there could be a small slideshow of all pictures (if more than one is availalbe, of course)

Contribute

vabene1111 commented 2 years ago

you can add images to steps so, is that sufficent for you ?

jscmidt commented 2 years ago

I think having multiple images to swipe between would be a nice feature. I don't really see the point in having images for steps, what's the use case for this?

vabene1111 commented 2 years ago

making instructions with images, thats what its for

smilerz commented 2 years ago

I don't really see the point in having images for steps, what's the use case for this?

A complicated step that requires a lot of manual manipulation of ingredients is the case I would use it for most commonly. Making Asian dumplings as one example.

jscmidt commented 2 years ago

A complicated step that requires a lot of manual manipulation of ingredients is the case I would use it for most commonly. Making Asian dumplings as one example.

Thanks, that makes sense. But then, in my opinion, step pictures aren’t a replacement for multiple recipe-images. However, I really understand that this isn’t an enhancement with high priority!

riker09 commented 2 years ago

Hello. I just tried to verify that on my Android phone. I'm not able to upload an image to a step. Are you referring to the textarea wysiwyg editor? I have not tried that.

This aside, I don't think that uploading images to steps would solve my use case. I simply would like to be able to add more than one picture to a recipe. On the recipe detail page there could be carousel that infity-scrolls through all available images. On the overview page a second picture could be shown when hovering an item with the mouse. I don't know a good way to present that on a mobile device, but I bet there is a way.

I believe one goal for me would be to see my process as a cook. This kinda touches the "protocol" feature where I can rate my cooking. Maybe this dialog should have the option to upload a picture as well?

And yes, this is very much no high-prio issue. I just thought it would make a good addition.

vabene1111 commented 2 years ago

uploading images to steps schuld work trough the "file" property of any given step but i have not tested that on android yet.

Multiple images for recipes are fine (altough i personally would not use them as steps) but shoudl be something we can migrate to in the future. We will generally need to keep an eye on how files are used in conjunction with recipes (i personally prefer to have the least amount of files possible but i also want to offer flexebility to those who want to use them)

dlaukamp commented 2 years ago

I installed my tandoor instance only a couple days ago and starting migrating my existing recipes into it. While I am really glad that tandoor makes this process so smooth in many details and was pleasantly surprised on how easy it is to reuse ingredients/ units/ etc., I searched quite a while for the option to add multiple images to the recipe, thinking that I must have missed such an obvious feature.

Apparently, it doesn't seem to be that obvious or even in-demand, given that this issue is only a couple days old and does not seem to be a duplicate of similar requests in the past. Still, isn't it natural to expect that you could add a picture after re-cooking an existing recipe, showcasing your success (or at least genuine attempt) in reproducing the result?

And yes, this is very much no high-prio issue. I just thought it would make a good addition.

Basically this, definitely not a deal breaker.

B5m3M commented 2 years ago

I'm looking forward to a multiple-image feature. I love taking several Photos of the meals I cooked. For many not needed, for me it was almost a deal breaker if it wasn't for so many other great features in Tandoor.

smilerz commented 2 years ago

@dlaukamp & @B5m3M - given the use case you provided, would you like to have the pictures as part of the cooklog?

vabene1111 commented 2 years ago

@smilerz i think we should just migrate everything to the UserFiles system. This way we could add relations to any object to allow it to have files.

I must admit the main reason not doing this before is that i am afraid of breaking things with files, as it is much harder to make migrations there than when having Database migrations and while many people backup their database mediafiles are often neglected. So making this change requires a very very very high degree of caution and testing and thinking of all possible edge cases

dlaukamp commented 2 years ago

@dlaukamp & @B5m3M - given the use case you provided, would you like to have the pictures as part of the cooklog?

At least for me, I think of these pictures as a representation of the recipe itself, not as a documentation of when I did cook a specific recipe. I just created some entries in the cooklog for testing purposes and find it hard to imagine how to integrate the images there, purely from a layout perspective.

I think the original poster did already nail it - if multiple images are available, have a slideshow instead of a static picture right at the top.

the main reason not doing this before is that i am afraid of breaking things with files, as it is much harder to make migrations there than when having Database migrations

Thank you for the explanation, I couldn't really make sense of the earlier "I prefer to have the least amount of files".

rubenixnagios commented 2 years ago

you can add images to steps so, is that sufficent for you ?

Im not able to add images to steps...anyone can send further instructions? @vabene1111 is that a link somewhere to add images? can't find it... thanks in advance!

smilerz commented 2 years ago

image

rubenixnagios commented 2 years ago

thanks @smilerz and sorry for posting before updating to latest release!! once updated can see File Button!! lovely!! great work!! I translated to catalan a long time ago so there will be loads of strings untranslated...

vabene1111 commented 2 years ago

thanks for your contribution, you can always hop on translate.tandoor.dev and translate some more if you want or just enjoy tandoor in english/mixed.

rubenixnagios commented 2 years ago

thanks for your contribution, you can always hop on translate.tandoor.dev and translate some more if you want or just enjoy tandoor in english/mixed.

alright, I will do a little by a little as am quite busy adding family recipes to tandoor xDDD catanglish tandoor does not look that bad anyway ;P

HarHarLinks commented 2 years ago

I would like to add multiple images/videos/files to some steps, and have them look nice like a gallery.

rubenixnagios commented 2 years ago

already posted some new strings to translate.tandoor.dev will this be available on next release? do i have to create a pull request? thanks again!! great job

vabene1111 commented 2 years ago

If you added something on the translate system it should automatically be included in the next release. Thanks for your contribution.

Maschine2 commented 1 year ago

I also support the request for multiple images shown as a slideshow or "gallery" on the recipe level (not hidden in steps). My use case is to show different views of the same cooked recipe or different varieties from the same recipe:

vabene1111 commented 1 year ago

understood. I personally think that I want to move recipe images to the "UserFile" system so that I have one generic way of handling all files, compression and so on.