TandoorRecipes / recipes

Application for managing recipes, planning meals, building shopping lists and much much more!
https://docs.tandoor.dev
Other
5.34k stars 562 forks source link

Unable to create or use custom filters #2008

Open nough opened 2 years ago

nough commented 2 years ago

Apologies, as I expect that this is a feature that is being worked on. In which case, I hope you don't mind having it as a list of things that don't currently work?

Unable to create custom filters: To access custom filters, I click on the toolbox at the top-right then files, then I click on the dropdown next to files and select Custom Filter. On each of the other list screens, I get a + button to create items, but not on the custom filter screen.

When custom filters exist, unable to edit the search I used the API to create two custom filters, with the search "plenty" and "yottam Ottolenghi". The word plenty is in the title of some of my external recipes, while "yottam ottolenghi" is a keyword. I could see these two custom filters existed from the API, but when using the List menu in Tandoor, I'm unable to even see the search keyword - only the title and who it's shared with.

I'm also unable to see if the custom filter has resulted in any items - so my next point may not be valid.

When custom filters exist, unable to use them for filtering in to recipe books I am able to edit the recipe book that I created for Plenty by Yottam Ottolenghi, and I can manually add recipes to the book. However, the book has a search filter which uses a custom filter. This was my reason for exploring the whole custom filter saga above. When one of these custom filters exist, I am able to select it in the recipe book edit menu. However this does not add the expected recipes to the recipe book.

smilerz commented 2 years ago

The interface needs some work to avoid some of this confusion.

image

Custom Filters can only be created from the search screen. The toolbox page you found can only be used to edit the name, share with another user (required if you share cookbooks with others) and delete the filter. Once created, the filters themselves cannot be modified.

smilerz commented 2 years ago
nough commented 2 years ago

I don't know if I'm looking at the right place, but I don't think there is an add button on custom filter toolbox page.

I agree that the help text is all that's necessary - I've managed to make the rest of it work now.

nough commented 2 years ago

I did - I mentioned that there wasn't one there!

smilerz commented 2 years ago

I did - I mentioned that there wasn't one there!

thanks - I misread it.

vabene1111 commented 2 years ago

Honestly my preferred solution would be (and that's probably what I will implement in the long run)

DorianHawkmoon commented 1 month ago

In the meantime, is there a hacky way to remove a created filter? I tried going to the admin page and see if I could find the data table so I can remove the entry, but no luck.

nough commented 1 month ago

Use the API, maybe?

https://tandoor.fqdn/api/custom-filter/

On Sat, 17 Aug 2024, 10:10 Dorian Hawkmoon, @.***> wrote:

In the meantime, is there a hacky way to remove a created filter? I tried going to the admin page and see if I could find the data table so I can remove the entry, but no luck.

— Reply to this email directly, view it on GitHub https://github.com/TandoorRecipes/recipes/issues/2008#issuecomment-2294802883, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHJDV5TRYM764WUFB5QWFLZR4HRFAVCNFSM6AAAAABMVIDNZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJUHAYDEOBYGM . You are receiving this because you authored the thread.Message ID: @.***>

DorianHawkmoon commented 1 month ago

Thanks! it worked, I had to search in https://tandoor.fqdn/docs/api/ in order to find the specific api for removing filters

Use the API, maybe? https://tandoor.fqdn/api/custom-filter/ On Sat, 17 Aug 2024, 10:10 Dorian Hawkmoon, @.> wrote: In the meantime, is there a hacky way to remove a created filter? I tried going to the admin page and see if I could find the data table so I can remove the entry, but no luck. — Reply to this email directly, view it on GitHub <#2008 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHJDV5TRYM764WUFB5QWFLZR4HRFAVCNFSM6AAAAABMVIDNZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJUHAYDEOBYGM . You are receiving this because you authored the thread.Message ID: @.>

smilerz commented 1 month ago

In the meantime, is there a hacky way to remove a created filter? I tried going to the admin page and see if I could find the data table so I can remove the entry, but no luck.

image